This repository has been archived by the owner on Jul 20, 2018. It is now read-only.
Fix GPG key retrieval and apply resilient key retrieval to slim Dockerfiles #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Syntax error: end of file unexpected (expecting "done")`
Closed
|
@hmalphettes any chance we can get this in before the PR to the official registry is merged? |
|
Done in iojs: 5478095 |
hmalphettes
added a commit
to hmalphettes/official-images
that referenced
this pull request
Sep 5, 2015
A regression was introduced here: nodejs/docker-iojs#87 It is fixed here: nodejs/docker-iojs#88
|
Added to the official-images PR: docker-library/official-images#1029 |
|
👍, LGTM. Thanks! |
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
A regression was introduced here: nodejs/docker-iojs#87 It is fixed here: nodejs/docker-iojs#88
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker Machine gave me the following when trying to build from the Dockerfiles with resilient GPG key retrieval added in #87:
Fixed by adding a semicolon before
done, and also applied resilient key retrieval to the slim Dockerfiles.