This repository has been archived by the owner on Jul 20, 2018. It is now read-only.
Update "gpg" usage to be more resilient to transient failure #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @yosifkit! LGTM |
|
Yeah, when build testing docker-library/official-images#1000 I ran into this, so I thought I would fix it 😄. |
Starefossen
added a commit
that referenced
this pull request
Aug 27, 2015
Update "gpg" usage to be more resilient to transient failure
hmalphettes
added a commit
to hmalphettes/official-images
that referenced
this pull request
Sep 5, 2015
A regression was introduced here: nodejs/docker-iojs#87 It is fixed here: nodejs/docker-iojs#88
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
A regression was introduced here: nodejs/docker-iojs#87 It is fixed here: nodejs/docker-iojs#88
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to docker-library/php#92, when
gpgis given multiple keys, it will only exit non-zero if all the keys fail to download so sometimes we'll get this line succeeding, but a transient failure (network, keyserver, or otherwise) can cause us to get a false positive and a build that fails later at verifying binaries.