Fix #17: Migrate source to Kotlin #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From a cursory glance on my phone this looks great! |
deepy
reviewed
Jan 7, 2020
| } | ||
|
|
||
| // Configurable; Groovy support | ||
| fun setExecOverrides(execOverrides: Closure<ExecSpec>) { |
There was a problem hiding this comment.
note to self: I think we might be able to replace Closure with Action
deepy
approved these changes
Jan 7, 2020
deepy
reviewed
Jan 7, 2020
|
I've looked through it and it seems great, just gotta run some manual tests before merging! |
|
Thanks @mikejhill for this great pull request! And thanks @deepy for reviewing it! |
|
Thank you for all the work @mikejhill! I'll be able to do a thorough test on the 20th when I got access to a project that's really good at triggering corner-cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a stab at migrating source to Kotlin. Let me know if this seems helpful. I tried to keep this to refactoring and minimize functional changes.
As users of the plugin, we would like to take advantage of some Gradle features that are easier to implement using Kotlin, e.g. #39.