Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kotlin as plugin language (instead of Groovy) #17

Closed
imanushin opened this issue Jun 12, 2019 · 4 comments
Closed

Use kotlin as plugin language (instead of Groovy) #17

imanushin opened this issue Jun 12, 2019 · 4 comments
Assignees
@deepy
Milestone
3.0

Comments

@imanushin
Copy link

Question to plugin owner: probably it is better to use Kotlin language for plugin next development?

Why:

  • It is first-class citizen of Gradle for now
  • We can have strong-typed language for:
    ** Configuration (with IntelliSence at the IntelliJ Idea)
    ** Plugin development
  • It is a bit faster than groovy (because of compilation)
@deepy
Copy link
Member

deepy commented Jun 12, 2019

I'm all for this, I really really do not enjoy Groovy and would much prefer Kotlin, probably a good target for a 3.x release

@deepy deepy added this to the 3.x milestone Jun 12, 2019
@bsautel bsautel mentioned this issue Oct 19, 2019
Closed
@deepy deepy self-assigned this Oct 22, 2019
deepy added a commit that referenced this issue Jan 10, 2020
@deepy
Merge pull request #57 from mikejhill/issue-17-migrate-to-kotlin
befb313 
#17: Migrate source to Kotlin
@deepy
Copy link
Member

deepy commented Jan 20, 2020

With Mike's PR this has been solved 🎉

@deepy deepy closed this as completed Jan 20, 2020
@bsautel
Copy link
Contributor

bsautel commented Jan 25, 2020

@deepy , maybe we could also rename in this version the package names (com.moowork) that were not changed until now to maintain backward compatibility?

@deepy
Copy link
Member

deepy commented Jan 27, 2020

@bsautel I suspect we broke backwards compatibility on day 1, we can only ever have one plugin applied per project and if both is on the classpath Something Strange™ is happening.

With that said I'm perfectly in support for moving away from the com.moowork namespace

stuartraetaylor added a commit to stuartraetaylor/gradle-node-plugin that referenced this issue Nov 24, 2020
@stuartraetaylor
Merge tag '3.0.0-rc4' into multifix
75f8efb 
3.0.0-rc4 - kotlin rewrite, lazy configuration, api changes, proxy fixes.
* Plugin rewritten in Kotlin (issue node-gradle#17) (thanks mikejhill for the pull request)
* Improved Kotlin DSL support
* Upgraded default Node.js version to 12.18.1 (bundled with npm 6.14.5), the latest LTS version
* Lazy configuration support
* Fix some remaining input/output declaration issues (issue node-gradle#34)
* Gradle 5.6.4+ support (instead of Gradle 5.0.0+ before)
* Node.js 10+ support (issue node-gradle#100)
* Use http:// for both HTTP and HTTPS_PROXY
* No longer configures proxy if there's already proxy settings present
* Support for npm 7+ node-gradle#123

See CHANGELOG for full details and upgrade instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepy deepy

Labels
None yet
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@deepy @bsautel @imanushin