Skip to content

[Fusilli] Pick compiler fixes and change dispatch count checks for conv3d#2560

Merged
sjain-stanford merged 4 commits into
nod-ai:mainfrom
sjain-stanford:sambhav/bump
Oct 23, 2025
Merged

[Fusilli] Pick compiler fixes and change dispatch count checks for conv3d#2560
sjain-stanford merged 4 commits into
nod-ai:mainfrom
sjain-stanford:sambhav/bump

Conversation

@sjain-stanford
Copy link
Copy Markdown
Member

@sjain-stanford sjain-stanford commented Oct 20, 2025

@sjain-stanford sjain-stanford changed the title [Fusilli] Pick compiler fixes https://github.com/iree-org/iree/pull/22320 and change dispatch count checks for conv3d [Fusilli] Pick compiler fixes and change dispatch count checks for conv3d Oct 20, 2025
@IanWood1
Copy link
Copy Markdown
Contributor

The reason CPU dispatch count improved is because we are generalizing convs. This is most likely causing really slow perf on CPU. It doesn't seem to be too problematic but this can be disabled with --iree-global-opt-experimental-disable-conv-generalization and there is an open IREE issue iree-org/iree#21955 to fix the bad perf

Copy link
Copy Markdown
Contributor

@IanWood1 IanWood1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 20, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@bb82cc9). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2560   +/-   ##
=======================================
  Coverage        ?   77.55%           
=======================================
  Files           ?      263           
  Lines           ?    25127           
  Branches        ?        0           
=======================================
  Hits            ?    19486           
  Misses          ?     5641           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sjain-stanford
Copy link
Copy Markdown
Member Author

this can be disabled with --iree-global-opt-experimental-disable-conv-generalization and there is an open IREE issue iree-org/iree#21955 to fix the bad perf

If this is only an intermittent state and given we're not tracking CPU perf atm, let's leave this as-is for now and hope it gets pulled the next time we bump IREE.

…_backend.so from build dir not the global TheRock install)
@sjain-stanford sjain-stanford merged commit 52e12fe into nod-ai:main Oct 23, 2025
42 of 43 checks passed
@sjain-stanford sjain-stanford deleted the sambhav/bump branch October 23, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants