Add ONNX metadata and versions as MLIR attributes. #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added per docs I am working on for the torch lowerings.
dan-garvey
approved these changes
Nov 21, 2023
Member
dan-garvey
left a comment
dan-garvey
left a comment
There was a problem hiding this comment.
Fine by me as long as you think it doesn't need a test
Contributor
Author
This is all just being tested for smoke right now. Need a bit more selectivity and e2e tests for detailed tests. They will come. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added per docs I am working on for the torch lowerings: llvm/torch-mlir#2585