-
Notifications
You must be signed in to change notification settings - Fork 627
Initial TorchOnnxToTorch conversion pipeline. #2585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added per docs I am working on for the torch lowerings: llvm/torch-mlir#2585
a0548d8 to
4fda711
Compare
Add docs. Match metadata attrs to the impl. Add conversions. CI Remove stray filecheck
4fda711 to
0224a69
Compare
vivekkhandelwal1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Drive-by nit: double-check that |
Adapts to the TorchOnnxToTorch changes from #2585. Also restores bazel builds in post-merge CI that was disabled in 2148c4c. Bazel workflow: https://github.com/sjain-stanford/torch-mlir/actions/runs/7023912962
Thanks. I did double check. I think this is good enough for now and once we get enough support to be real, we can assess/ask/etc. if we have to change it, we are at the level of a fancy sed command in the future, so I think it is fine to defer for now in favor of just moving forward. |
Adds a pipeline to convert custom ops and metadata represented as
torch.operatorcustom ops to correspondingtorchops where possible.This is part of a multi-part approach for building ONNX import in as a regular feature of torch-mlir. It is focused on the conversions vs the infra. We will end up maintaining a pure-python importer to go with this in torch-mlir, and we will also maintain test case generation utilities derived from it.
I have left substantial documentation in the README of the conversion directory, including the recommended approach that we will take to keep building this out.
(note that this organizes the code to coincide with the refactoring in #2442 versus the current flat arrangement)