Skip to content

fix(acp): backfill missing text chunks from part updates #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkosi23 merged 1 commit into from
Mar 1, 2026
Merged

fix(acp): backfill missing text chunks from part updates #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions packages/opencode/src/acp/agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ export namespace ACP {
private eventStarted = false
private bashSnapshots = new Map<string, string>()
private toolStarts = new Set<string>()
private textSnapshots = new Map<string, string>()
private permissionQueues = new Map<string, Promise<void>>()
private permissionOptions: PermissionOption[] = [
{ optionId: "once", kind: "allow_once", name: "Allow once" },
Expand Down Expand Up @@ -446,6 +447,46 @@ export namespace ACP {
return
}
}

if (part.type === "text" && part.ignored !== true) {
const delta = this.textDelta(part.id, part.text)
if (!delta) return
await this.connection
.sessionUpdate({
sessionId,
update: {
sessionUpdate: "agent_message_chunk",
content: {
type: "text",
text: delta,
},
},
})
.catch((error) => {
log.error("failed to send text update to ACP", { error })
})
return
}

if (part.type === "reasoning") {
const delta = this.textDelta(part.id, part.text)
if (!delta) return
await this.connection
.sessionUpdate({
sessionId,
update: {
sessionUpdate: "agent_thought_chunk",
content: {
type: "text",
text: delta,
},
},
})
.catch((error) => {
log.error("failed to send reasoning update to ACP", { error })
})
return
}
return
}

Expand Down Expand Up @@ -476,6 +517,7 @@ export namespace ACP {
if (!part) return

if (part.type === "text" && props.field === "text" && part.ignored !== true) {
this.textSnapshots.set(part.id, part.text)
await this.connection
.sessionUpdate({
sessionId,
Expand All @@ -494,6 +536,7 @@ export namespace ACP {
}

if (part.type === "reasoning" && props.field === "text") {
this.textSnapshots.set(part.id, part.text)
await this.connection
.sessionUpdate({
sessionId,
Expand Down Expand Up @@ -1085,6 +1128,14 @@ export namespace ACP {
return output
}

private textDelta(id: string, next: string) {
const prev = this.textSnapshots.get(id) ?? ""
this.textSnapshots.set(id, next)
if (!next) return ""
if (next.startsWith(prev)) return next.slice(prev.length)
return next
}

private async toolStart(sessionId: string, part: ToolPart) {
if (this.toolStarts.has(part.callID)) return
this.toolStarts.add(part.callID)
Expand Down