Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
message.part.deltadelivery, causing assistant output to appear truncated until a later refresh.message.part.updatedarrives so ACP clients receive output incrementally.Description
textSnapshots: Map<string,string>topackages/opencode/src/acp/agent.tsto track the last-seen text for each part id.message.part.updatedfortextandreasoningparts by computing the missing delta viatextDelta(id, next)and emitting anagent_message_chunkoragent_thought_chunkcontaining only the new text.message.part.deltahandling to keeptextSnapshotsin sync (store full part text) so delta and updated events don’t cause duplicate emission.Testing
bun run typecheckwhich failed in this environment becausetsgois not installed.bun test src/acp --timeout 30000which executed successfully but matched no test files.bun test --timeout 30000which failed in this environment due to missing local dependencies (e.g.zod,remeda,hono) and registry access errors, so CI-style tests could not be completed here.Codex Task