Skip to content

flake: update all inputs#1881

Merged
trueNAHO merged 1 commit intonix-community:masterfrom
0xda157:update-sep-03
Sep 5, 2025
Merged

flake: update all inputs#1881
trueNAHO merged 1 commit intonix-community:masterfrom
0xda157:update-sep-03

Conversation

@0xda157
Copy link
Copy Markdown
Contributor

@0xda157 0xda157 commented Sep 4, 2025

Our lockfiles are getting very out of date (and have been blocking prs). I don't want to wait until #1817 is fixed to keep things update to date.


@0xda157 0xda157 requested a review from trueNAHO September 4, 2025 05:10
@stylix-automation stylix-automation bot added topic: dependencies Dependency updates topic: flake /flake.nix, /flake.lock, and /flake/ subsystems labels Sep 4, 2025
trueNAHO added a commit to 0xda157/stylix that referenced this pull request Sep 4, 2025
Update all inputs, rename the KDE platform, and apply formatter changes
by running the following commands:

    biome check --write --unsafe
    pre-commit run --all-files

Rename the KDE platform, following local commit f47c0ed ("treewide:
remove Plasma 5 support dropped upstream (nix-community#1860)") and upstream commits
[1] ("nixos/treewide: clean up some more references to deleted qt5
things") and [2] ("qt: deprecate kde6").

[1]: NixOS/nixpkgs@31d5c4e
[2]: nix-community/home-manager@1e75978

Closes: nix-community#1865
Link: nix-community#1866
Link: nix-community#1881

Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Co-authored-by: Samuel Meenzen <samuel@meenzen.net>
Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
@stylix-automation stylix-automation bot added topic: documentation Documentation additions or improvements topic: nixos NixOS target topic: home-manager Home Manager target topic: darwin nix-darwin target topic: droid Nix-on-Droid target topic: testbed Testbed changes topic: modules /modules/ subsystem topic: stylix /stylix/ subsystem labels Sep 4, 2025
@stylix-automation stylix-automation bot requested a review from danth September 4, 2025 23:23
Update all inputs, rename the KDE platform, and apply formatter changes
by running the following commands:

    biome check --unsafe --write
    pre-commit run --all-files

Rename the KDE platform, following local commit f47c0ed ("treewide:
remove Plasma 5 support dropped upstream (nix-community#1860)") and upstream commits
[1] ("nixos/treewide: clean up some more references to deleted qt5
things") and [2] ("qt: deprecate kde6").

[1]: NixOS/nixpkgs@31d5c4e
[2]: nix-community/home-manager@1e75978

Closes: nix-community#1865
Link: nix-community#1866
Link: nix-community#1881

Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Co-authored-by: Samuel Meenzen <samuel@meenzen.net>
Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Copy link
Copy Markdown
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved breaking changes and cherry-picked #1866, which was pending on this nix flake update:

commit 9fd508fc9b38d9b047f501c866cd995cc49add52
Author: awwpotato <awwpotato@voidq.com>
Date:   2025-09-03 22:07:54 -0700

    flake: update all inputs

    Update all inputs, rename the KDE platform, and apply formatter changes
    by running the following commands:

        biome check --unsafe --write
        pre-commit run --all-files

    Rename the KDE platform, following local commit f47c0edcf71e ("treewide:
    remove Plasma 5 support dropped upstream (#1860)") and upstream commits
    [1] ("nixos/treewide: clean up some more references to deleted qt5
    things") and [2] ("qt: deprecate kde6").

    [1]: https://github.com/NixOS/nixpkgs/commit/31d5c4e753c996f5fd431b9988af9db91581ec09
    [2]: https://github.com/nix-community/home-manager/commit/1e759786e526a87a3c05beeff5db41743d763569

    Closes: https://github.com/nix-community/stylix/issues/1865
    Link: https://github.com/nix-community/stylix/pull/1866
    Link: https://github.com/nix-community/stylix/pull/1881

    Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
    Co-authored-by: Samuel Meenzen <samuel@meenzen.net>
    Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>

Interestingly, the "Request Reviewers" GitHub Action works again on this PR for some reason. Maybe it worked because of the force push?

@trueNAHO trueNAHO mentioned this pull request Sep 4, 2025
6 tasks
Copy link
Copy Markdown
Member

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM - For clarity it may be better to keep these as separate commits.

Copy link
Copy Markdown
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

OK, let's just merge this then.

For clarity it may be better to keep these as separate commits.

This is one atomic breaking change and splitting it up results in partially invalid states:

  • - flake: update all inputs          # This is broken without the other two commits.
    - treewide: apply formatter changes
    - qt: rename KDE platform
    
  • - treewide: apply formatter changes # This is broken without pulling the formatter changes.
    - qt: rename KDE platform           # This just happens to not crash CI, although it should depend on the updates.
    - flake: update all inputs
    

This is why I put everything into one commit.

@trueNAHO trueNAHO merged commit 0e7b897 into nix-community:master Sep 5, 2025
6 checks passed
thomas-bouvier added a commit to thomas-bouvier/my-dotfiles that referenced this pull request Sep 5, 2025
@trueNAHO
Copy link
Copy Markdown
Member

trueNAHO commented Sep 5, 2025

CC: @awwpotato, @danth

We should require PRs to be rebased on top of this PR to avoid CI formatting failures once they are merged into master, even if they passed in the PR itself.

@0xda157 0xda157 deleted the update-sep-03 branch September 9, 2025 18:48
MrSom3body pushed a commit to MrSom3body-contrib/stylix that referenced this pull request Sep 18, 2025
Update all inputs, rename the KDE platform, and apply formatter changes
by running the following commands:

    biome check --unsafe --write
    pre-commit run --all-files

Rename the KDE platform, following local commit f47c0ed ("treewide:
remove Plasma 5 support dropped upstream (nix-community#1860)") and upstream commits
[1] ("nixos/treewide: clean up some more references to deleted qt5
things") and [2] ("qt: deprecate kde6").

[1]: NixOS/nixpkgs@31d5c4e
[2]: nix-community/home-manager@1e75978

Closes: nix-community#1865
Link: nix-community#1866
Link: nix-community#1881

Reviewed-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Co-authored-by: Samuel Meenzen <samuel@meenzen.net>
Co-authored-by: NAHO <90870942+trueNAHO@users.noreply.github.com>
Reviewed-by: Daniel Thwaites <danth@danth.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: darwin nix-darwin target topic: dependencies Dependency updates topic: documentation Documentation additions or improvements topic: droid Nix-on-Droid target topic: flake /flake.nix, /flake.lock, and /flake/ subsystems topic: home-manager Home Manager target topic: modules /modules/ subsystem topic: nixos NixOS target topic: stylix /stylix/ subsystem topic: testbed Testbed changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants