qt: fix kde platformTheme

[meenzen]

closes #1865

---

Submission Checklist

• I certify that I have the right to submit this contribution under the MIT license
• Commit messages adhere to Stylix commit conventions
• Theming changes adhere to the Stylix style guide
• Changes have been tested locally
• Changes have been tested in testbeds
• Each commit in this PR is suitable for backport to the current stable branch

[0xda157]

Copilot review requested due to automatic review settings

hmm not sure what this is about, we should figure out how to disable this cc @trueNAHO @danth

[trueNAHO]

Copilot review requested due to automatic review settings

hmm not sure what this is about, we should figure out how to disable this cc @trueNAHO @danth

AFAIK, I have never clicked on anything inside the GitHub interface that says "AI" or "Copilot". Maybe this is a transitive change done by the nix-community organization?

[0xda157]

Copilot review requested due to automatic review settings

hmm not sure what this is about, we should figure out how to disable this cc @trueNAHO @danth

AFAIK, I have never clicked on anything inside the GitHub interface that says "AI" or "Copilot". Maybe this is a transitive change done by the nix-community organization?

It seems the author of this pr probably has it enabled for all the prs they create, we should probably make a policy on LLMs for Stylix.

[trueNAHO]

From a quick read, it seems Home Manager maintains aliases:

•   # Maps style names to their QT_QPA_PLATFORMTHEME, if necessary.
    styleNames = {
      gtk = "gtk2";
      qtct = "qt5ct";
      kde6 = "kde";
    };

  -- github:nix-community/home-manager, /modules/misc/qt.nix:45

•         lib.mkOption {
            type =
              with lib.types;
              nullOr (
                either (enum [
                  "gtk"
                  "gtk3"
                  "gnome"
                  "adwaita"
                  "lxqt"
                  "qtct"
                  "kde"
                  "kde6"
                ]) (lib.types.submodule { options = newOption; })
              );

  -- github:nix-community/home-manager, /modules/misc/qt.nix:213

Should we also replace "kde6" with "kde" in our Home Manager module, and potentially upstream this?

[trueNAHO]

Copilot review requested due to automatic review settings

hmm not sure what this is about, we should figure out how to disable this cc [trueNAHO danth]

AFAIK, I have never clicked on anything inside the GitHub interface that says "AI" or "Copilot". Maybe this is a transitive change done by the nix-community organization?

It seems the author of this pr probably has it enabled for all the prs they create, we should probably make a policy on LLMs for Stylix.

Is it not possible to disable Copilot repo-wide in some setting? From a quick search 1 2 3, this seems like an unsolved Computer Science problem...

Since this is the first time this happens, we can just ignore this for now. AFAIK, the Nix community does not really use Copilot, so this should rarely happen.

[meenzen]

Yeah sorry about the confusion, copilot review was enabled for all of my MRs. It has nothing to do with this specific repo.

[trueNAHO]

Aside from resolving #1866 (review), is this PR ready to merge? This PR is currently in draft mode.

[meenzen]

This was just my quick and dirty attempt to fix the issue. Since Home Manager is currently broken as well I am not able to verify this fix yet.

[meenzen]

Now that home-manager has been fixed (nix-community/home-manager#7746) I can confirm this fixes the build for me.

[trueNAHO]

Now that home-manager has been fixed (nix-community/home-manager#7746) I can confirm this fixes the build for me.

LGTM. However, ideally this PR should not be merged without updating our relevant inputs. I have cherry-picked this patch into #1881, superseding this PR.

[trueNAHO]

I have cherry-picked this patch into #1881, superseding this PR.

Superseded-by: 0e7b897

Thanks for fixing this.