stylix: conditionally load external modules in testbeds#1698
Merged
0xda157 merged 1 commit intonix-community:masterfrom Jul 19, 2025
Merged
Conversation
0xda157
reviewed
Jul 15, 2025
trueNAHO
force-pushed
the
stylix-conditionally-load-external-modules-in-testbeds
branch
from
f24a9a2 to
0063077
Compare
0xda157
approved these changes
Jul 15, 2025
Contributor
0xda157
left a comment
0xda157
left a comment
There was a problem hiding this comment.
LGTM, lets wait for @Flameopathic's review
Conditionally load external modules in testbeds to preserve testbed integrity by preventing unrelated code from running and potentially invalidating its meaning. Any performance benefit is merely a side effect of this more targeted module loading.
trueNAHO
force-pushed
the
stylix-conditionally-load-external-modules-in-testbeds
branch
from
0063077 to
669f9bd
Compare
Flameopathic
approved these changes
Jul 19, 2025
Contributor
Flameopathic
left a comment
Flameopathic
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your patience
0xda157
approved these changes
Jul 19, 2025
stylix-automation bot
pushed a commit
that referenced
this pull request
Jul 19, 2025
Conditionally load external modules in testbeds to preserve testbed integrity by preventing unrelated code from running and potentially invalidating its meaning. Any performance benefit is merely a side effect of this more targeted module loading. Link: #1698 Reviewed-by: awwpotato <awwpotato@voidq.com> Reviewed-by: Flameopathic <64027365+Flameopathic@users.noreply.github.com> (cherry picked from commit 24499b0)
Contributor
|
Successfully created backport PR for |
0xda157
pushed a commit
that referenced
this pull request
Jul 19, 2025
Conditionally load external modules in testbeds to preserve testbed integrity by preventing unrelated code from running and potentially invalidating its meaning. Any performance benefit is merely a side effect of this more targeted module loading. Link: #1698 Reviewed-by: awwpotato <awwpotato@voidq.com> Reviewed-by: Flameopathic <64027365+Flameopathic@users.noreply.github.com> (cherry picked from commit 24499b0)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a friendly reminder to include the original commit message in the merged commit:
Things done
Tested locally
Tested in testbed
The following testbeds evaluate:
nix build .#testbed:{alacritty,nixvim,nvf,spicetify}:darkCommit message follows commit convention
Fits style guide
Respects license of any existing code used
Notify maintainers
@Flameopathic @awwpotato