Skip to content

flake: update nvf dev input#1673

Merged
0xda157 merged 1 commit intonix-community:masterfrom
trueNAHO:flake-update-nvf-dev-input
Jul 11, 2025
Merged

flake: update nvf dev input#1673
0xda157 merged 1 commit intonix-community:masterfrom
trueNAHO:flake-update-nvf-dev-input

Conversation

@trueNAHO
Copy link
Copy Markdown
Member

Update the nvf dev input to pull commit [1] ("flake: follow flake-parts
and flake-utils inputs"), reducing our number of unique dependencies.

[1]: https://github.com/NotAShelf/nvf/commit/607675ac6e1c99318c65b4ffc4a87d935d787072

For reference, if NotAShelf/nvf#1001 gets merged, it further decreases our number of unique dependencies. Since it only affects nvf's internal inputs, this requires no additional action on our end other than updating nvf.

-- #1579 (review)

With NotAShelf/nvf#1001 merged, this PR pulls only the desired changes: NotAShelf/nvf@a82b228...8ea010d.

Things done

Notify maintainers

Update the nvf dev input to pull commit [1] ("flake: follow flake-parts
and flake-utils inputs"), reducing our number of unique dependencies.

[1]: NotAShelf/nvf@607675a
Copy link
Copy Markdown
Contributor

@0xda157 0xda157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing that

@0xda157 0xda157 merged commit 0da583a into nix-community:master Jul 11, 2025
6 checks passed
@stylix-automation
Copy link
Copy Markdown
Contributor

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-1673-to-release-25.05 origin/release-25.05
cd .worktree/backport-1673-to-release-25.05
git switch --create backport-1673-to-release-25.05
git cherry-pick -x 0da583a359fd911d5cbfd2c789424b888b777a4b

stylix-automation bot pushed a commit that referenced this pull request Jul 13, 2025
Link: #1673

Reviewed-by: awwpotato <awwpotato@voidq.com>
(cherry picked from commit 0da583a)
@stylix-automation
Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-25.05:

0xda157 pushed a commit that referenced this pull request Jul 13, 2025
Link: #1673

Reviewed-by: awwpotato <awwpotato@voidq.com>
(cherry picked from commit 0da583a)
LunaCOLON3 pushed a commit to LunaCOLON3/stylix that referenced this pull request Jul 14, 2025
Link: nix-community#1673

Reviewed-by: awwpotato <awwpotato@voidq.com>
@trueNAHO
Copy link
Copy Markdown
Member Author

@awwpotato, remember to include the original commit message (or a reworded version) in the final squash commit message when appropriate. For example, this seems to have been missed in this PR and #1659.

@0xda157
Copy link
Copy Markdown
Contributor

0xda157 commented Jul 15, 2025

@awwpotato, remember to include the original commit message (or a reworded version) in the final squash commit message when appropriate. For example, this seems to have been missed in this PR and #1659.

yeah sorry about that I'll make sure to look over the pr description and comments before merging in the future.

@trueNAHO
Copy link
Copy Markdown
Member Author

trueNAHO commented Jul 15, 2025

[awwpotato], remember to include the original commit message (or a reworded version) in the final squash commit message when appropriate. For example, this seems to have been missed in this PR and #1659.

yeah sorry about that I'll make sure to look over the pr description and comments before merging in the future.

From my experience, GitHub never populates the commit body with the original commit message. Very occasionally, it at best copy-pastes the entire PR description, which is obviously very bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants