Add overrides for tensorflow-macos #791
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the direct override for
tensorflow-macos
, and addssetuptools
asbuildInputs
for three of its dependencies.With this change, the only user requirement to get
tensorflow-macos
working is a workaround for #750.I was unsure of a few things.
This works with
buildInputs
, so I've used that (rather than, saypropagatedBuildInputs
) — I presume this is the correct choice?The direct overrides for
tensorflow-macos
should probably be the same as those fortensorflow
itself, but I don't know whether that is desirable.If it is not, then the final commit can be dropped.
(If it is then the latter two commits should probably be merged.)
I've backported the changes from a personal override; I don't really know what the testing policy is, here.
Thanks; happy to contribute this upstream!