Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overrides for tensorflow-macos #791

Merged

Conversation

dbaynard
Copy link
Contributor

@dbaynard dbaynard commented Nov 2, 2022

This adds the direct override for tensorflow-macos, and adds setuptools as buildInputs for three of its dependencies.
With this change, the only user requirement to get tensorflow-macos working is a workaround for #750.

I was unsure of a few things.

  1. This works with buildInputs, so I've used that (rather than, say propagatedBuildInputs) — I presume this is the correct choice?

  2. The direct overrides for tensorflow-macos should probably be the same as those for tensorflow itself, but I don't know whether that is desirable.
    If it is not, then the final commit can be dropped.
    (If it is then the latter two commits should probably be merged.)

I've backported the changes from a personal override; I don't really know what the testing policy is, here.

Thanks; happy to contribute this upstream!

@dbaynard
Copy link
Contributor Author

dbaynard commented Nov 3, 2022

Ah, just seen (#792) that the way to handle what I do in the first commit is adding entries in build-systems.json. I'll update the PR.

This is needed for tensorflow-macos
In both cases, the `tensorboard` executable conflicts with that from
`tensorboard` itself.
@adisbladis adisbladis merged commit 6b3afb0 into nix-community:master Nov 4, 2022
@dbaynard dbaynard deleted the overrides/tensorflow-macos branch November 4, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants