-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infinite recursion encountered
#750
Comments
Here's a minimal repro case:
|
Also need the contents of your pyproject.toml and lock file. |
pyproject.toml
poetry.lock
|
@asymmetric There were some follow up PRs recently merged that may fix your issue here. Can you check against |
I get something similar with Traceback
I think this might be an interaction between the package name normalization added in #736 and The package name for babel @ 2.10.3 is Both Then in poetry2nix we set This results in a cycle because now |
Is there any intermediate way to fix it? |
Thank you @asymmetric . I assume I need a specific version of nixpkgs too, in order to solve the setup tools issue? Do you happen to know what that version is? |
For those who need just to upgrade one package the Poetry 1.1.15 still generates old style packages names and [email protected] will successfully parse them , so you don't have to go and update every possible dependency. |
@thiagorp I have only tried this with 22.05, not sure what newer versions would work. |
I'm seeing the same issue. I'm using nixos-unstable channel and latest master of poetry2nix. I've created the lock with 1.2.2 and 1.1.15 poetry, but still i'm getting the same error. |
@asymmetric I've got the same problem with infinite recursion (3b9040d and NixOS/nixpkgs@80d4d59 including trying 22.05 and latest from today) when What works for now is creating a { poetry2nix
, pkgs
, ...
}:
let
preDefaults = self: super: {
# XXX: Unset babel/Babel and rename to babel_ to avoid infinit recursion
# then in postDefaults we set `babel_` back to `babel`
babel = null;
Babel = null;
babel_ = super.babel;
};
postDefaults = self: super: {
# XXX: Avoid infinit recursion
babel = super.babel_;
};
in
(poetry2nix.defaultPoetryOverrides.overrideOverlay preDefaults).extend postDefaults I encountered this problem yesterday evening when trying to upgrade I also have to use my fork (icetan/poetry2nix@06a79b95b9) with the feature to filter out things from the lock file using Hope this helps and that there is a more long term solution soon. |
For the record, a similar problem has been reported also against mach-nix: DavHau/mach-nix#470 |
This worked for me, too, but with Much like how The comment in DavHau/mach-nix#470 (comment) seems to be close to what is going on, no, given the fix? I had to update various packages to add |
Works around nix-community/poetry2nix#750 > infinite recursion encountered The issue, as pointed out in DavHau/mach-nix#470 (comment), is that nixpkgs defines ``` Keras = keras; ``` https://github.com/NixOS/nixpkgs/blob/fbb042bc87bc92fc5296b8b151e36970dd996c64/pkgs/top-level/python-aliases.nix poetry2nix must (somewhere) set `keras` to depend on `Keras` meaning infinite recursion. The fix is based on the code in nix-community/poetry2nix#750 (comment)
Works around nix-community/poetry2nix#750 > infinite recursion encountered The issue, as pointed out in DavHau/mach-nix#470 (comment), is that nixpkgs defines ``` Keras = keras; ``` https://github.com/NixOS/nixpkgs/blob/fbb042bc87bc92fc5296b8b151e36970dd996c64/pkgs/top-level/python-aliases.nix poetry2nix must (somewhere) set `keras` to depend on `Keras` meaning infinite recursion. The fix is based on the code in nix-community/poetry2nix#750 (comment)
Describe the issue
Since #736 got merged (I confirmed by pinning the commit in the flake input), I'm getting this error:
Additional context
trace
``` warning: Git tree '/home/asymmetric/code/foo/bar' is dirty error: infinite recursion encounteredThe text was updated successfully, but these errors were encountered: