include base.nix for more filesystems support#363
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
yuyuyureka
force-pushed
the
add-iso-base
branch
from
077e4f8 to
01955ce
Compare
flokli
reviewed
Jan 15, 2026
Remove environment.systemPackages, as base.nix provides a reasonable default for the installer. Explicitly keep ZFS support disabled to avoid build failures. We match the latest-kernel specialisation in this regard.
yuyuyureka
force-pushed
the
add-iso-base
branch
from
01955ce to
6a5a8dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to match the capabilities (partitioning / formatting / rescue tools, filesystems...) generally provided in NixOS installer ISOs.
Note that minimal.nix and base.nix profiles do not contradict. base.nix adds new tools, while minimal.nix reduces the image size by disabling documentation etc.
Blocking:
1. The ZFS implications of this need to be discussedAs discussed with flokli, and previously mentioned by tpwrules, we explicitly keep ZFS support disabled to avoid build failures and match the latest-kernel specialisation of the upstream ISOs. So this PR does not change anything about ZFS support.
2. The next staging-next cycle (NixOS/nixpkgs#444862) needs to be merged since this fixes bcache-tools in the cross iso