Expose installer as a module#353
Merged
Merged
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/custom-asahi-installer/69034/6 |
ac90e4a to
417278f
Compare
|
This is very helpful! It has merge conflicts |
Contributor
Author
|
Merge conflict was super minor, resolved. |
Member
|
Not meant to be blocking, but can you create a followup PR describing how to build your own installers? That'd be particularly useful if someone for example wants to enable ZFS (c.f. #363). |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to expose the iso-configuration to flake outputs, which will make it significantly easier for end users to create their own customized installer images.
For example, in my case I have been greatly enjoying Asahi NixOS on ZFS root, and so having ZFS support in the installer makes things much easier!
With this PR, users like myself can easily create their own installer image with ZFS support (and git, for flakes and rsync), like so:
There may be a way to use some overrides with the existing
installer-bootstrapoutput, but if so, I haven't yet figured it out: https://discourse.nixos.org/t/custom-asahi-installer