treefmt: refactor, treefmt2, pipelines #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zowoq
force-pushed
the
treefmt
branch
3 times, most recently
from
d7e248f to
8a507e7
Compare
|
@brianmcgee I do have a couple of questions. I don't understand why With the rust version the verbose output would show the command and files, is that still possible? |
|
I just checked out the branch and ran About git, we no longer use git directly instead we use https://github.com/go-git/go-git. It looks like it's unable to read your local git state for some reason, possibly it's corrupt since it worked with a fresh clone for me. Can you try a fresh clone and see what happens on your side? Info level logging will show the pipelines: Debug level doesn't show the command though. I am currently improving the logging, I can add that in. |
Created numtide/treefmt#292 |
Seems to be an issue with my
Great, thanks. |
|
Seems the problem was |
|
Ok cool, I'll get that updated |
brianmcgee
added a commit
to numtide/treefmt
that referenced
this pull request
May 17, 2024
Switches go-git to master for now until a new release is cut. Related to: nix-community/infra#1266 Closes #293 Signed-off-by: Brian McGee <[email protected]>
brianmcgee
added a commit
to numtide/treefmt
that referenced
this pull request
May 17, 2024
Switches go-git to master for now until a new release is cut. Related to: nix-community/infra#1266 Fixes #293 Signed-off-by: Brian McGee <[email protected]>
|
Just cut a new release candidate with the improvements above: https://github.com/numtide/treefmt/releases/tag/v2.0.0-rc2 You can switch back to |
Thanks, I've opened a PR for this in nixpkgs: NixOS/nixpkgs#312559 Not sure how to get the editorconfig check to work with numtide/treefmt#297? It is a linter intended to be run against everything? Lines 30 to 34 in 1a8c378 It also catches actionlint/prettier and mypy/ruff: f757770 TBH I think numtide/treefmt#297 a bit too strict, I don't want to have to put everything into a pipeline. |
|
Thanks for the PR, meant to create it myself but got distracted. This is quite a complex config, which is good for pushing the new pipelines approach. You raise an interesting point about editorconfig, and I don't have a good answer yet. I'll try and find some time this weekend to spend on coming up with an answer. |
|
Don't feel pressured to resolve this quickly. I've made with simple workaround for editorconfig so we can move forward with this PR as the treefmt pipelines are a good improvement. |
zowoq
force-pushed
the
treefmt
branch
2 times, most recently
from
5b1cbaf to
d259604
Compare
also move editorconfig to a separate check as it isn't currently compatible with treefmt pipelines
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.