Skip to content

firefox: remove old unused test file#6403

Merged
teto merged 1 commit intonix-community:masterfrom
kira-bruneau:remove-old-test-file
Feb 6, 2025
Merged

firefox: remove old unused test file#6403
teto merged 1 commit intonix-community:masterfrom
kira-bruneau:remove-old-test-file

Conversation

@kira-bruneau
Copy link
Copy Markdown
Contributor

@kira-bruneau kira-bruneau commented Feb 3, 2025

Description

It looks like this file was unexpectedly added back in #5686 while resolving a conflict with #5697.

It's not used in any test, and all the changes that were added to this file in #5686 have also been included in:

  • tests/modules/programs/firefox/profiles/search/default.nix
  • tests/modules/programs/firefox/profiles/bookmarks/default.nix

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@brckd @rycee @Mikilio

@Mikilio
Copy link
Copy Markdown
Contributor

Mikilio commented Feb 4, 2025

I remember very well that I have actively worked on these tests to make them work as they where not working with the new mkFirefoxModule setup and that I was also upset this file was removed and caused a merge conflict.

The tests don't run in the CI as it is marked as a big test. These tests need to be run manually.
Like so:

nix build -L .#test-floorp-profiles-bookmarks
nix build -L .#test-floorp-profiles-search
nix build -L .#test-firefox-profiles-bookmarks
nix build -L .#test-firefox-profiles-search

@kira-bruneau
Copy link
Copy Markdown
Contributor Author

kira-bruneau commented Feb 4, 2025

The tests don't run in the CI as it is marked as a big test. These tests need to be run manually. Like so:

nix build -L .#test-floorp-profiles-bookmarks
nix build -L .#test-floorp-profiles-search
nix build -L .#test-firefox-profiles-bookmarks
nix build -L .#test-firefox-profiles-search

Like I mentioned in the PR description, those tests don't use profile-settings.nix, they use:

  • tests/modules/programs/firefox/profiles/search/default.nix
  • tests/modules/programs/firefox/profiles/bookmarks/default.nix

It looks like the changes from your PR were moved into those files, but profile-settings.nix isn't used anymore.

@Mikilio
Copy link
Copy Markdown
Contributor

Mikilio commented Feb 4, 2025

Ah, now I see. I do indeed see my added snippets duplicated in two files. Looks like I was too lazy when resolving the conflict, I apologize for that.

@kira-bruneau
Copy link
Copy Markdown
Contributor Author

No worries!

@teto teto merged commit 15bd673 into nix-community:master Feb 6, 2025
teto pushed a commit to teto/home-manager that referenced this pull request Feb 11, 2025
tetov pushed a commit to tetov/home-manager that referenced this pull request Feb 16, 2025
@brckd brckd mentioned this pull request Feb 18, 2025
347Online pushed a commit to 347Online/home-manager that referenced this pull request Mar 1, 2025
nfelber pushed a commit to nfelber/home-manager that referenced this pull request Mar 19, 2025
@kira-bruneau kira-bruneau deleted the remove-old-test-file branch April 7, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants