firefox: Enable userChrome in about:config by MrQubo · Pull Request #5670 · nix-community/home-manager

MrQubo · 2024-07-25T04:05:47Z

Description

Enable "toolkit.legacyUserProfileCustomizations.stylesheets" in about:config if userChrome is not empty.
Resolves #5666

Change is not backwards compatible. It will break configs where userChrome is set to non-empty string and settings."toolkit.legacyUserProfileCustomizations.stylesheets" is set to false. It seems unlikely but I've added assertion nevertheless.

Checklist

Change is backwards compatible.
Code formatted with ./format.
Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.
Test cases updated/added. See example.
Commit messages are formatted like
```
{component}: {description}

{long description}
```
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
- Added myself as module maintainer. See example.

Maintainer CC

@rycee @kira-bruneau

MrQubo · 2024-07-25T04:12:18Z

~~Here's a more friendly diff without indentation changes:~~

MrQubo · 2024-07-25T04:14:14Z

I've tried running tests with nix-shell --pure tests -A run.all but I'm getting error error: executing shell '/nix/store/p5441mp6wwpdh65qamaixvd092cwr45h-bash-interactive-5.2p26/bin/bash': Argument list too long. :/

EDIT: nix develop --ignore-environment '.#firefox-profile-settings' worked.

IldenH

Really like this change as it is confusing having the stylesheets not work despite being set.

MrQubo · 2024-07-29T18:11:27Z

I hate github, I was replying you, but it was "pending" so I think you didn't see any of that. ;_;

kira-bruneau · 2024-07-30T16:07:18Z

It looks like this needs to rebased since: #5128

MrQubo · 2024-07-30T22:34:35Z

Rebased, I've made some additional changes, could you review again? Completely unrelated change, but the containers test was bugging me.

kira-bruneau · 2024-07-30T23:05:36Z

      id = 5;
      containers = {
        "shopping" = {
-          id = 6;


Wait what was wrong with the containers test? Each container should have its own unique id set, so I think it makes sense to keep one explicitly set in the test.

It was a bit confusing, because it's container id, not profile id. It looks like someone set it to 6 because it's the next number after 5, but these ids are unrelated. I feel like there's no need to set container id here (apart from making this test failproof against changing the default container id), and it's not testing anything.

I could set it explicitly to 1, but using 6 here is a bit confusing, because it looks like it's related to this 5.

kira-bruneau · 2024-08-01T18:05:57Z

+            {option}`${userChromeAttr}` won't work with
+            {option}`settings."toolkit.legacyUserProfileCustomizations.stylesheets"` set to false.


I'm not sure if you saw my other comment on this since it was in a resolved thread, but {option}`x` shouldn't be used in assertions, because they don't get rendered like the docs do.

Ok. I left the backticks characters.

MrQubo · 2024-08-08T14:27:35Z


-      "${profilesPath}/${profile.path}/user.js" = mkIf (profile.settings != { }
-        || profile.extraConfig != "" || profile.bookmarks != [ ]) {
+      "${cfg.profilesPath}/${profile.path}/user.js" = mkIf (profile.settings


I think it hurts readability how ./format broke the line before !=. :/

MrQubo · 2024-08-08T14:49:53Z

I (hopefully) fixed the tests on macos.

MrQubo · 2024-08-08T14:59:48Z

Maybe it would be easier to fix the tests in #5698 and keep this PR self-contained.

kira-bruneau · 2024-08-08T15:30:32Z

Maybe it would be easier to fix the tests in #5698 and keep this PR self-contained.

Thanks @MrQubo! I'll push the fix to #5698 if it passes here.

kira-bruneau · 2024-08-08T18:48:04Z

It looks like it's still failing here

MrQubo · 2024-08-16T08:40:20Z

@kira-bruneau I can't understand why it's failing.

stale · 2024-11-17T18:14:23Z

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
If it is unfinished but you plan to finish it, please mark it as a draft.
If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

MrQubo · 2024-11-19T01:39:56Z

Seems like macos tests where fixed in master.

MrQubo · 2024-11-19T03:10:10Z

Now ubuntu tests are broken in master. ;_;

Enable "toolkit.legacyUserProfileCustomizations.stylesheets" in about:config if userChrome or userContent is not empty.

MrQubo · 2024-11-20T23:08:17Z

The code moved from default.nix to mkFirefoxModule.nix, but the changes are still the same.

MrQubo · 2024-11-20T23:28:37Z

No idea what is the error now.
It says "NOTE: If your Manual build passes locally and you see this message in CI, you probably need a rebase", but I already rebased onto master.

nyabinary · 2025-02-06T00:58:30Z

No idea what is the error now. It says "NOTE: If your Manual build passes locally and you see this message in CI, you probably need a rebase", but I already rebased onto master.

Is this working at its current state, or are there still errors?

MrQubo · 2025-02-24T13:23:14Z

Tests on this PR need fixing, see: #6403

stale · 2025-06-18T22:18:44Z

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
If it is unfinished but you plan to finish it, please mark it as a draft.
If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

MrQubo force-pushed the firefox-userChrome-enable-in-settings branch from 5307a99 to b73f112 Compare July 25, 2024 04:06

MrQubo marked this pull request as draft July 25, 2024 04:18

MrQubo force-pushed the firefox-userChrome-enable-in-settings branch from b73f112 to fc80b16 Compare July 25, 2024 04:31

MrQubo marked this pull request as ready for review July 25, 2024 04:34

MrQubo force-pushed the firefox-userChrome-enable-in-settings branch from fc80b16 to e68817e Compare July 25, 2024 04:38

kira-bruneau reviewed Jul 26, 2024

View reviewed changes

Comment thread modules/programs/firefox.nix Outdated

IldenH suggested changes Jul 29, 2024

View reviewed changes

MrQubo force-pushed the firefox-userChrome-enable-in-settings branch from e68817e to e286638 Compare July 29, 2024 18:05

IldenH approved these changes Jul 29, 2024

View reviewed changes

MrQubo force-pushed the firefox-userChrome-enable-in-settings branch from e286638 to 4205c1f Compare July 30, 2024 22:32

kira-bruneau reviewed Jul 30, 2024

View reviewed changes

kira-bruneau mentioned this pull request Aug 1, 2024

thunderbird: support setting search engines #5697

Merged

6 tasks

kira-bruneau reviewed Aug 1, 2024

View reviewed changes

Comment thread modules/programs/firefox/mkFirefoxModule.nix Outdated

MrQubo force-pushed the firefox-userChrome-enable-in-settings branch 3 times, most recently from d1aee34 to e9e0e61 Compare August 7, 2024 00:27

kira-bruneau approved these changes Aug 7, 2024

View reviewed changes

MrQubo force-pushed the firefox-userChrome-enable-in-settings branch from e9e0e61 to 2682ad9 Compare August 8, 2024 14:26

MrQubo commented Aug 8, 2024

View reviewed changes

MrQubo force-pushed the firefox-userChrome-enable-in-settings branch from 2682ad9 to 615a348 Compare August 8, 2024 14:32

stale bot added the status: stale label Nov 17, 2024

MrQubo force-pushed the firefox-userChrome-enable-in-settings branch from 615a348 to c4707bf Compare November 19, 2024 01:26

stale bot removed the status: stale label Nov 19, 2024

MrQubo force-pushed the firefox-userChrome-enable-in-settings branch from c4707bf to 1cd9311 Compare November 19, 2024 01:35

firefox: Enable userChrome in about:config

008a165

Enable "toolkit.legacyUserProfileCustomizations.stylesheets" in about:config if userChrome or userContent is not empty.

MrQubo force-pushed the firefox-userChrome-enable-in-settings branch from 1cd9311 to 008a165 Compare November 20, 2024 22:57

MrQubo requested review from kira-bruneau and rycee November 20, 2024 23:07

kira-bruneau mentioned this pull request Feb 5, 2025

firefox: Support paths for userChrome & userContent #3856

Merged

7 tasks

teto added the program: firefox label Feb 6, 2025

khaneliman added the merge conflict label Mar 19, 2025

stale bot added the status: stale label Jun 18, 2025

		{option}`${userChromeAttr}` won't work with
		{option}`settings."toolkit.legacyUserProfileCustomizations.stylesheets"` set to false.

Uh oh!

Conversation

MrQubo commented Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Maintainer CC

Uh oh!

MrQubo commented Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MrQubo commented Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

IldenH left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MrQubo commented Jul 29, 2024

Uh oh!

kira-bruneau commented Jul 30, 2024

Uh oh!

MrQubo commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kira-bruneau Jul 30, 2024

Choose a reason for hiding this comment

Uh oh!

MrQubo Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

kira-bruneau Aug 1, 2024

Choose a reason for hiding this comment

Uh oh!

MrQubo Aug 5, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MrQubo Aug 8, 2024

Choose a reason for hiding this comment

Uh oh!

MrQubo commented Aug 8, 2024

Uh oh!

MrQubo commented Aug 8, 2024

Uh oh!

kira-bruneau commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kira-bruneau commented Aug 8, 2024

Uh oh!

MrQubo commented Aug 16, 2024

Uh oh!

stale bot commented Nov 17, 2024

Uh oh!

MrQubo commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MrQubo commented Nov 19, 2024

Uh oh!

MrQubo commented Nov 20, 2024

Uh oh!

MrQubo commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nyabinary commented Feb 6, 2025

Uh oh!

MrQubo commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stale bot commented Jun 18, 2025

Uh oh!

Reviewers

MrQubo commented Jul 25, 2024 •

edited

Loading

MrQubo commented Jul 25, 2024 •

edited

Loading

MrQubo commented Jul 25, 2024 •

edited

Loading

MrQubo commented Jul 30, 2024 •

edited

Loading

kira-bruneau commented Aug 8, 2024 •

edited

Loading

MrQubo commented Nov 19, 2024 •

edited

Loading

MrQubo commented Nov 20, 2024 •

edited

Loading

MrQubo commented Feb 24, 2025 •

edited

Loading