Skip to content

hypridle: configurable systemd target#5981

Closed
tristanbeedell wants to merge 1 commit intonix-community:masterfrom
tristanbeedell:hypridle
Closed

hypridle: configurable systemd target#5981
tristanbeedell wants to merge 1 commit intonix-community:masterfrom
tristanbeedell:hypridle

Conversation

@tristanbeedell
Copy link
Copy Markdown
Contributor

Description

Allows you to set the systemd target for hypridle. Also allows you to disable the service.
I set the service to default to true to preserve backward compatibility.
The options layout is based off waybar's.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

Note

this is based on master, which appears to have broken test neovim-plugin-config
https://github.com/nix-community/home-manager/actions/runs/11422914607/job/31781473809

Maintainer CC

@fufexan @khaneliman

Copy link
Copy Markdown
Contributor

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice

Copy link
Copy Markdown
Collaborator

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tristanbeedell
Copy link
Copy Markdown
Contributor Author

rebased onto master, which has fixed the problem test, thanks @khaneliman: #5976

@tristanbeedell tristanbeedell force-pushed the hypridle branch 2 times, most recently from cea1959 to 013192e Compare November 3, 2024 14:20
@tristanbeedell
Copy link
Copy Markdown
Contributor Author

Hi, not sure what I've done to break the test pipelines... never thought I'd say this but it works on my machine

@fufexan
Copy link
Copy Markdown
Contributor

fufexan commented Nov 3, 2024

Looks like the rebase broke tests. Which is weird, because tests aren't failing on master.

@khaneliman
Copy link
Copy Markdown
Collaborator

Looks like the rebase broke tests. Which is weird, because tests aren't failing on master.

Looks like an alacritty test too :S

@fufexan
Copy link
Copy Markdown
Contributor

fufexan commented Nov 3, 2024

Yeah, I meant it broke unrelated tests. Which is weird.

@khaneliman
Copy link
Copy Markdown
Collaborator

khaneliman commented Nov 3, 2024

Want to try rebasing and force pushing again to trigger CI? I checked your branch out and the tests passed locally for me.

@tristanbeedell
Copy link
Copy Markdown
Contributor Author

orphaned by #6086

@tristanbeedell tristanbeedell deleted the hypridle branch November 25, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants