modules/neovim: fix config generation#5976
Merged
teto merged 1 commit intonix-community:masterfrom Oct 21, 2024
Merged
Conversation
2 tasks
Collaborator
|
not sure if you took a peek at #5964 but that looks correct ;) if tests are good then we're good. My PR does a bit more so it is probably best to fix the problem at hand with your PR. |
Collaborator
Author
Yeah, I saw the other before when we first noticed checks failing. Didn’t know if you still had work to do on that so threw together a bandaid |
|
@teto This appears to work for me. |
Collaborator
|
once again thank you . I failed to edit the commit message on merge but next time, try to provide more details please :p |
5 tasks
colonelpanic8
pushed a commit
to colonelpanic8/home-manager
that referenced
this pull request
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just trying to fix the recent breakage with config generation, follow up to NixOS/nixpkgs#344541. @teto would like you to sanity check me here...
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@rycee @teto