Skip to content

modules/neovim: fix config generation#5976

Merged
teto merged 1 commit intonix-community:masterfrom
khaneliman:neovim
Oct 21, 2024
Merged

modules/neovim: fix config generation#5976
teto merged 1 commit intonix-community:masterfrom
khaneliman:neovim

Conversation

@khaneliman
Copy link
Copy Markdown
Collaborator

@khaneliman khaneliman commented Oct 19, 2024

Description

Just trying to fix the recent breakage with config generation, follow up to NixOS/nixpkgs#344541. @teto would like you to sanity check me here...

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@rycee @teto

@teto
Copy link
Copy Markdown
Collaborator

teto commented Oct 21, 2024

not sure if you took a peek at #5964 but that looks correct ;) if tests are good then we're good. My PR does a bit more so it is probably best to fix the problem at hand with your PR.

@khaneliman
Copy link
Copy Markdown
Collaborator Author

not sure if you took a peek at #5964 but that looks correct ;) if tests are good then we're good. My PR does a bit more so it is probably best to fix the problem at hand with your PR.

Yeah, I saw the other before when we first noticed checks failing. Didn’t know if you still had work to do on that so threw together a bandaid

@tmiller
Copy link
Copy Markdown

tmiller commented Oct 21, 2024

@teto This appears to work for me.

@teto teto merged commit 5ec753a into nix-community:master Oct 21, 2024
@teto
Copy link
Copy Markdown
Collaborator

teto commented Oct 21, 2024

once again thank you . I failed to edit the commit message on merge but next time, try to provide more details please :p

@khaneliman khaneliman deleted the neovim branch October 21, 2024 23:49
colonelpanic8 pushed a commit to colonelpanic8/home-manager that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants