chromium: fix commandLineArgs to use the user specified package

[ThinkChaos]

Description

commandLineArgs were only being applied when the user didn't override the package option.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

[networkException]

The note in

home-manager/modules/programs/chromium.nix

Lines 45 to 46 in a6c284d

	Note this option does not have any effect when using a
	custom package for <option>programs.${browser}.package</option>.

does not apply anymore with this patch.

[ThinkChaos]

Good catch, thanks! Force pushed to remove that.

As for your PR, my goal was pretty much the same, so either solution is fine by me!
For reference, there's already somewhat explicit support via browser = if drvName == "ungoogled-chromium" then "chromium" else drvName; since ungoogled-chromium uses the same config dir as chromium.

[sumnerevans]

I think that the approach in #4174 is better since it allows you to easily install and configure multiple versions of chromium-based browsers in a single HM install.

[networkException]

Anything against also merging this? I don't really see why commandLineArgs would need to be limited to supported browsers

[sumnerevans]

For some reason I read this as removing options in options.programs.* but looking closer this is just changing it to pass pkgs.* instead of browserPkgs.* and then overriding within browserModule.