chromium: add support for ungoogled-chromium

[networkException]

Description

This pull request adds support for using programs.ungoogled-chromium and various options like commandLineArgs.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

[networkException]

Alternatively #4175 also solves the commandLineArgs issue with ungoogled-chromium

[sumnerevans]

darwinDirs needs to be updated as well (line 139)

[networkException]

Isn't that covered by the expression in line 136? Also I don't think there are darwin builds for ungoogled-chromium

[sumnerevans]

Oh, I didn't notice the or browser expression on line 150. Looks like ungoogled-chromium in nixpkgs is in fact only built for Linux: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/applications/networking/browsers/chromium/browser.nix#L91

Though, there appears to be darwin builds for ungoogled-chromium at least here: https://github.com/ungoogled-software/ungoogled-chromium/releases/tag/114.0.5735.198-1, but I guess nobody on Darwin cares enough to package it.

Edit: I think that we should still include it, just in case anyone ever packages it for nixpkgs, or if they just package it themselves.

[sumnerevans]

I installed Ungoogled Chromium on my Mac test machine and it looks like the path is just Library/Application Support/Chromium. Let's go ahead and add that for completeness sake.

[ThinkChaos]

Tested this locally and it works for me!

[ThinkChaos]

I realized that I could configure extensions using programs.chromium just fine which was my goal with using this change. I had misread the existing code and thought the extensions options was disabled.
Now I'm less convinced adding programs.ungoogled-chromium is good:

• using programs.chromium with package = pkgs.ungoogled-chromium allows configuring everything this does
• programs.chromium and programs.ungoogled-chromium both use the same config directory, which different options in HM doesn't model properly

Is the goal here to make ungoogled-chromium more discoverable?
Making ungoogled-chromium the example for options.chromium.program could be enough to point towards that.

[networkException]

No my intention was the same as your pr (I marked it as an alternative because of that). I don't mind closing this either

[stale]

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

• GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
• If it is unfinished but you plan to finish it, please mark it as a draft.
• If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
• To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

• If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

[folliehiyuki]

Hi! Is there anything preventing this PR from being merged?

It works and I don't want to keep a patched home-manager URL in my flake input forever to configure ungoogled-chromium.

[stale]

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

• GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
• If it is unfinished but you plan to finish it, please mark it as a draft.
• If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
• To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

• If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

[merrkry]

It seems no extra work is required to support ungoogled-chromium. Would be very nice if this got merged.

[stackptr]

I think this should be closed for reasons mentioned in #4174 (review)

[stale]

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

• GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
• If it is unfinished but you plan to finish it, please mark it as a draft.
• If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
• To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

• If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.