Merged
Conversation
pywal allows to change your theme for much software: https://github.com/dylanaraps/pywal/wiki/Customization#table-of-contents home-manager is the perfect tool to leverage since a single setting could enable wal-compatible theming for all this software. In this PR, I've just enabled zsh, kitty and i3 but I hope follow up PRs will enable more software. At some point we may even need a blacklist. Once enabled, run: wal --theme random to change your colorschemes.
rycee
reviewed
May 9, 2022
rycee
reviewed
May 9, 2022
Member
|
Thanks, looks fine to me! Just a few minor comments. |
Member
What if we had an option that enables/disables it by default for every tool and then manually enable it? |
Member
|
There was a similar PR last year for a tool called "Flavours", see #2165 |
Collaborator
Author
that's my intention. I wanted to merge initial support so that others can join in the effort plus it makes other additions easier.
I had completely missed it thanks interesting. Looking forward to that PR being reopened :) |
Collaborator
Author
|
damn I realized I had a copy of the module in my dotfiles and realized that after removing it could not load the pywal module from HM. I''ve also found an issue with rofi and have added neovim support locally. Please dont revert, I will fix soon |
astratagem
added a commit
to astratagem/home-manager
that referenced
this pull request
May 17, 2022
commit dce4a3d Author: Chris Montgomery <chris@cdom.io> Date: Tue Apr 5 22:44:12 2022 -0400 gpg-agent: add option to specify pinentry package this is useful for macOS, where `pkgs.pinentry_mac` may be preferable to one of the `pkgs.pinentry` flavors. commit 9ee03d5 Author: Chris Montgomery <chris@cdom.io> Date: Wed Mar 16 10:54:19 2022 -0400 gpg-agent: add launchd service for darwin commit 32a7da6 Author: Peng Guanwen <pg999w@outlook.com> Date: Thu May 5 09:14:02 2022 +0200 Translate using Weblate (Chinese (Simplified)) Currently translated at 85.7% (12 of 14 strings) Co-authored-by: Peng Guanwen <pg999w@outlook.com> Translate-URL: https://hosted.weblate.org/projects/home-manager/modules/zh_Hans/ Translation: Home Manager/Home Manager Modules commit 273598f Author: Sumner Evans <me@sumnerevans.com> Date: Fri May 13 08:27:23 2022 -0600 mako: add package option (nix-community#2955) commit f735a85 Author: Matthieu Coudron <teto@users.noreply.github.com> Date: Tue May 10 22:24:19 2022 +0200 programs.pywal: init (nix-community#2949) commit 4293902 Author: Markus Scherer <markus.f.scherer@gmail.com> Date: Tue May 10 09:30:40 2022 +0200 offlineimap: remove dependency on python2 (nix-community#2909) (nix-community#2951) commit 882bd81 Author: Aidan Gauland <aidalgol@users.noreply.github.com> Date: Sat May 7 13:27:31 2022 +1200 gtk: Update example strings for gtk.theme.package (nix-community#2904) - Change the example value of `gtk.theme.package` from `pkgs.gnome.gnome_themes_standard` was an alias that was removed on 2022-01-13, `pkgs.gnome-themes-extra`, which references the actual package. - Change the example value of `gtk.icon.package` from `pkgs.adwaita-icon-theme` to `pkgs.gnome.adwaita-icon-theme`, as this package is in the `gnome` package set.
jevy
pushed a commit
to jevy/home-manager
that referenced
this pull request
Jul 1, 2022
Member
|
You might be interested in nix-colors. It's something I came up with to replace flavours in my home-manager setup :) |
teto
added a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pywal allows to change your theme for much software:
https://github.com/dylanaraps/pywal/wiki/Customization#table-of-contents
home-manager is the perfect tool to leverage since a single setting
could enable wal-compatible theming for all this software.
In this PR, I've just enabled zsh, kitty and i3 but I hope follow up PRs will
enable more software.
At some point we may even need a blacklist.
Once enabled, run:
wal --theme random
to change your colorschemes.
edit: for neovim support we would need dylanaraps/wal.vim#26
Description
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.