Skip to content

gtk: Update example strings for gtk.theme.package#2904

Merged
berbiche merged 2 commits intonix-community:masterfrom
aidalgol:gtk-theme-pkg-example-update
May 7, 2022
Merged

gtk: Update example strings for gtk.theme.package#2904
berbiche merged 2 commits intonix-community:masterfrom
aidalgol:gtk-theme-pkg-example-update

Conversation

@aidalgol
Copy link
Copy Markdown
Contributor

@aidalgol aidalgol commented Apr 20, 2022 •
edited
Loading

Description

Change the example value of gtk.theme.package from pkgs.gnome.gnome_themes_standard, which was an alias that was removed on 2022-01-13, to pkgs.gnome-themes-extra, which references the actual package.

Change the example value of gtk.icon.package from pkgs.adwaita-icon-theme to
pkgs.gnome.adwaita-icon-theme, as this package is in the gnome package set.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}

{long description}

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@aidalgol aidalgol requested a review from rycee as a code owner April 20, 2022 22:33
@berbiche
Copy link
Copy Markdown
Member

berbiche commented May 6, 2022

Hi, could you rebase your PR to fix the failing tests? Thanks.

Aidan Gauland added 2 commits May 7, 2022 09:24
@aidalgol
gtk: Update example string for gtk.theme.package
57c360c 
Change the example value of `gtk.theme.package` from
`pkgs.gnome.gnome_themes_standard` was an alias that was removed on 2022-01-13,
`pkgs.gnome-themes-extra`, which references the actual package.
@aidalgol
gtk: Update example string for gtk.icon.package
189f9fc 
Change the example value of `gtk.icon.package` from `pkgs.adwaita-icon-theme` to
`pkgs.gnome.adwaita-icon-theme`, as this package is in the `gnome` package set.
@aidalgol aidalgol changed the title gtk: Update example string for gtk.theme.package gtk: Update example strings for gtk.theme.package May 6, 2022
@aidalgol
Copy link
Copy Markdown
Contributor Author

aidalgol commented May 6, 2022

Hi, could you rebase your PR to fix the failing tests? Thanks.

Rebased and pushed. Just awaiting workflow approval.

@berbiche berbiche merged commit 882bd81 into nix-community:master May 7, 2022
astratagem added a commit to astratagem/home-manager that referenced this pull request May 17, 2022
@astratagem
Squashed commit of the following:
491cf5a 
commit dce4a3d
Author: Chris Montgomery <chris@cdom.io>
Date:   Tue Apr 5 22:44:12 2022 -0400

    gpg-agent: add option to specify pinentry package

    this is useful for macOS, where `pkgs.pinentry_mac` may be preferable to
    one of the `pkgs.pinentry` flavors.

commit 9ee03d5
Author: Chris Montgomery <chris@cdom.io>
Date:   Wed Mar 16 10:54:19 2022 -0400

    gpg-agent: add launchd service for darwin

commit 32a7da6
Author: Peng Guanwen <pg999w@outlook.com>
Date:   Thu May 5 09:14:02 2022 +0200

    Translate using Weblate (Chinese (Simplified))

    Currently translated at 85.7% (12 of 14 strings)

    Co-authored-by: Peng Guanwen <pg999w@outlook.com>
    Translate-URL: https://hosted.weblate.org/projects/home-manager/modules/zh_Hans/
    Translation: Home Manager/Home Manager Modules

commit 273598f
Author: Sumner Evans <me@sumnerevans.com>
Date:   Fri May 13 08:27:23 2022 -0600

    mako: add package option (nix-community#2955)

commit f735a85
Author: Matthieu Coudron <teto@users.noreply.github.com>
Date:   Tue May 10 22:24:19 2022 +0200

    programs.pywal: init (nix-community#2949)

commit 4293902
Author: Markus Scherer <markus.f.scherer@gmail.com>
Date:   Tue May 10 09:30:40 2022 +0200

    offlineimap: remove dependency on python2 (nix-community#2909) (nix-community#2951)

commit 882bd81
Author: Aidan Gauland <aidalgol@users.noreply.github.com>
Date:   Sat May 7 13:27:31 2022 +1200

    gtk: Update example strings for gtk.theme.package (nix-community#2904)

    - Change the example value of `gtk.theme.package` from
    `pkgs.gnome.gnome_themes_standard` was an alias that was removed on 2022-01-13,
    `pkgs.gnome-themes-extra`, which references the actual package.

    - Change the example value of `gtk.icon.package` from `pkgs.adwaita-icon-theme` to
    `pkgs.gnome.adwaita-icon-theme`, as this package is in the `gnome` package set.
jevy pushed a commit to jevy/home-manager that referenced this pull request Jul 1, 2022
@aidalgol @jevy
gtk: Update example strings for gtk.theme.package (nix-community#2904)
5d4fb37 
- Change the example value of `gtk.theme.package` from
`pkgs.gnome.gnome_themes_standard` was an alias that was removed on 2022-01-13,
`pkgs.gnome-themes-extra`, which references the actual package.

- Change the example value of `gtk.icon.package` from `pkgs.adwaita-icon-theme` to
`pkgs.gnome.adwaita-icon-theme`, as this package is in the `gnome` package set.
@teto teto mentioned this pull request Aug 22, 2022
Closed
7 tasks
teto pushed a commit to teto/home-manager that referenced this pull request Aug 22, 2022
@aidalgol
gtk: Update example strings for gtk.theme.package (nix-community#2904)
357bcd4 
- Change the example value of `gtk.theme.package` from
`pkgs.gnome.gnome_themes_standard` was an alias that was removed on 2022-01-13,
`pkgs.gnome-themes-extra`, which references the actual package.

- Change the example value of `gtk.icon.package` from `pkgs.adwaita-icon-theme` to
`pkgs.gnome.adwaita-icon-theme`, as this package is in the `gnome` package set.
spacekookie pushed a commit to spacekookie/home-manager that referenced this pull request Feb 10, 2023
@aidalgol @spacekookie
gtk: Update example strings for gtk.theme.package (nix-community#2904)
8056156 
- Change the example value of `gtk.theme.package` from
`pkgs.gnome.gnome_themes_standard` was an alias that was removed on 2022-01-13,
`pkgs.gnome-themes-extra`, which references the actual package.

- Change the example value of `gtk.icon.package` from `pkgs.adwaita-icon-theme` to
`pkgs.gnome.adwaita-icon-theme`, as this package is in the `gnome` package set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berbiche berbiche berbiche approved these changes

@rycee rycee Awaiting requested review from rycee

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aidalgol @berbiche