Skip to content

gpg-agent: make shell integrations optional (#2927)#2930

Merged
berbiche merged 1 commit intonix-community:release-21.11from
crazymanjinn:release-21.11
May 2, 2022
Merged

gpg-agent: make shell integrations optional (#2927)#2930
berbiche merged 1 commit intonix-community:release-21.11from
crazymanjinn:release-21.11

Conversation

@crazymanjinn
Copy link
Copy Markdown
Contributor

In esoteric setups, automatically setting GPG_TTY to current tty is not
desired on every shell startup. This change adds configuration options
to allow user to disable that if desired.

(cherry picked from commit df60105)

Description

Backports #2927

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

N/A

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module
    N/A

In esoteric setups, automatically setting GPG_TTY to current tty is not
desired on every shell startup. This change adds configuration options
to allow user to disable that if desired.

(cherry picked from commit df60105)
@crazymanjinn crazymanjinn requested a review from rycee as a code owner May 1, 2022 16:03
Copy link
Copy Markdown
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
This is reasonable and these options should have been provided 👍

Copy link
Copy Markdown
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@berbiche berbiche merged commit d93d56a into nix-community:release-21.11 May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants