gpg-agent: make shell integrations optional#2927
Merged
sumnerevans merged 2 commits intonix-community:masterfrom May 1, 2022
Merged
gpg-agent: make shell integrations optional#2927sumnerevans merged 2 commits intonix-community:masterfrom
sumnerevans merged 2 commits intonix-community:masterfrom
Conversation
In esoteric setups, automatically setting GPG_TTY to current tty is not desired on every shell startup. This change adds configuration options to allow user to disable that if desired.
sumnerevans
reviewed
Apr 30, 2022
sumnerevans
approved these changes
May 1, 2022
crazymanjinn
added a commit
to crazymanjinn/home-manager
that referenced
this pull request
May 1, 2022
In esoteric setups, automatically setting GPG_TTY to current tty is not desired on every shell startup. This change adds configuration options to allow user to disable that if desired. (cherry picked from commit df60105)
5 tasks
berbiche
pushed a commit
that referenced
this pull request
May 2, 2022
teto
pushed a commit
to teto/home-manager
that referenced
this pull request
Aug 22, 2022
In esoteric setups, automatically setting GPG_TTY to current tty is not desired on every shell startup. This change adds configuration options to allow user to disable that if desired.
spacekookie
pushed a commit
to spacekookie/home-manager
that referenced
this pull request
Feb 10, 2023
In esoteric setups, automatically setting GPG_TTY to current tty is not desired on every shell startup. This change adds configuration options to allow user to disable that if desired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In esoteric setups, automatically setting GPG_TTY to current tty is not
desired on every shell startup. This change adds configuration options
to allow user to disable that if desired.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Appears an unrelated test case is failing even before my change:
However, all the gpg-agent related tests do pass:
Change seems trivial enough it shouldn't need new testcases? Happy to be wrong, so please let me know if you would like me to add some.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
This PR does not.