systemd: fix creation of user service unit files

[andresilva]

Description

Fix #2846, diff provided by @yu-re-ka.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• If this PR adds a new module

  • Added myself as module maintainer. See example.

  • Added myself and the module files to .github/CODEOWNERS.

[andrevmatos]

This seems to be caused by NixOS/nixpkgs#162246 , but I'm not a big fan of the runCommand approach, instead of the utilities

[andrevmatos]

Ok, I tested several options, and it seems the issue is caused because of double-applying escapeShellArg after above PR.
The fix therefore is even simpler:

diff --git a/modules/systemd.nix b/modules/systemd.nix
index cd5b30ed..0be586d7 100644
--- a/modules/systemd.nix
+++ b/modules/systemd.nix
@@ -41,7 +41,7 @@ let
       source = pkgs.writeTextFile {
         name = pathSafeName;
         text = toSystemdIni serviceCfg;
-        destination = lib.escapeShellArg "/${filename}";
+        destination = "/${filename}";
       } + "/${filename}";
 
       wantedBy = target: {

[elizagamedev]

It seems like this PR does not have the second, simpler fix, is this a mistake?

[berbiche]

Sorry @andresilva, I took the liberty to force push the "simpler" fix on your branch.

[andresilva]

@berbiche no worries, made sense to get this merged asap and simpler is better :)

[genofire]

Is there any new release in NixOS/nixpkgs planned? That release is really outdated (and without this patch broken now)

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/builder-for-nix-store-failed-to-produce-output-path-nix-store-via-home-manager/18649/6

[timokau]

I have opened a nixpkgs PR: NixOS/nixpkgs#169084

[NorfairKing]

Could this be backported to release-22.05 and release-21.11?

EDIT: I found a better solution than to depend on a specific home-manager; depending on pkgs.home-manager.src