waybar: fix command not found when reloading

[danth]

Description

Currently, trying to run systemctl --user reload waybar.service fails with:

Apr 05 19:31:39 StarBook-MkV systemd[2313]: Reloading Highly customizable Wayland bar for Sway and Wlroots based compositors....
Apr 05 19:31:39 StarBook-MkV systemd[46289]: waybar.service: Failed to locate executable kill: No such file or directory
Apr 05 19:31:39 StarBook-MkV systemd[46289]: waybar.service: Failed at step EXEC spawning kill: No such file or directory
Apr 05 19:31:39 StarBook-MkV systemd[2313]: waybar.service: Control process exited, code=exited, status=203/EXEC
Apr 05 19:31:39 StarBook-MkV systemd[2313]: Reload failed for Highly customizable Wayland bar for Sway and Wlroots based compositors..

Fixed this by inserting the full path to the kill command from the busybox package.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

  See CONTRIBUTING for more information and recent commit messages for examples.

• (Extra:) Code tested on a live system.

[berbiche]

Thanks!

[berbiche]

Once #2867 is merged, you will have to rebase your changes to fix the failing tests.
I am unable to merge a PR with failing tests.

[danth]

@berbiche Sorry for the delay, I've rebased the changes now 😄

[sumnerevans]

Looks like the test needs to be fixed. It also needs test.stubs.coreutils = { }

[berbiche]

Looks like the test needs to be fixed. It also needs test.stubs.coreutils = { }

👍 though coreutils is very likely already part of the test closure.

[danth]

@sumnerevans test.stubs.coreutils causes an infinite recursion. What would you suggest I do?

[berbiche]

@sumnerevans test.stubs.coreutils causes an infinite recursion. What would you suggest I do?

In that case, there's no need for a stub 👍

[danth]

Used normalizeStorePaths instead of a stub; the test should be working now.

[danth]

Fixed formatting.