neovim: add extraLuaPackages to neovim, fixes #1964.

[ashinkarov]

Description

Extend neovim program to allow specifying additional lua libraries that will become available to neovim at runtime. See #1964 for further details.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all.

• Test cases updated/added.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

This is a rebased version of the #1970 which got closed by some reason, without being merged. Can we please merge this? @teto ?

[ashinkarov]

Can anybody initiate the ci on this pull request, @teto @rycee?

[ashinkarov]

Fellows, can you please help me figure out what is going on with the failing tests? If I look at the output of the run I see:

building '/nix/store/2k765k36lpjva3l84wzb48j97kxfxrmj-nmt-report-gh-config-file.drv'...
error: attribute 'override' missing

       at /nix/store/gdfpd7k0yyihpq1k05l4k0g33lx4n7jw-source/pkgs/top-level/all-packages.nix:25721:40:

        25720|
        25721|   gitMinimal = appendToName "minimal" (git.override {
             |                                        ^
        25722|     withManual = false;
(use '--show-trace' to show detailed location information)
Error: Process completed with exit code 1.

I doubt that the fail has to do with my changes.

Also, it seems the fail appears only after some very recent nixos update, as the tests ran cleanly when I opened the PR.

How do we go about it?

[berbiche]

building '/nix/store/2k765k36lpjva3l84wzb48j97kxfxrmj-nmt-report-gh-config-file.drv'...
error: attribute 'override' missing

       at /nix/store/gdfpd7k0yyihpq1k05l4k0g33lx4n7jw-source/pkgs/top-level/all-packages.nix:25721:40:

        25720|
        25721|   gitMinimal = appendToName "minimal" (git.override {
             |                                        ^
        25722|     withManual = false;
(use '--show-trace' to show detailed location information)
Error: Process completed with exit code 1.

Hi,

You need to rebase your changes on the "master" branch to have the fix that will resolve this test failure.

[ashinkarov]

Thanks, @berbiche ! I did the rebase. I guess somebody needs to approve the run of ci again. Can you do this?

[ashinkarov]

Dear @teto @rycee @berbiche, could you please initate the ci run for the pr, so that we could finally merge this in.

[teto]

'wrapLuaProgram' in nixpkgs should wrap automatically with LUA_(C)PATH. It might be broken though.

[ashinkarov]

'wrapLuaProgram' in nixpkgs should wrap automatically with LUA_(C)PATH. It might be broken though.

The last time I have tried, nvim still couldn't find the right library. Can we please merge this in, and then we'll try to improve it?

[teto]

Let's merge this until we have a better fix in nixpkgs