neovim: add extraLuaPackages to neovim, fixes #1964.

[ashinkarov]

Description

Extend neovim program to allow specifying additional lua libraries that will become available to neovim at runtime. See #1964 for further details.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all. The tests die on my machine, but aparently for the reasons that has nothing to do with my changes. I hope that github's CI would pick it up so we can discuss what's going on.

• Test cases updated/added. See example. I am not sure whether this change needs any tests. Does it?

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

[sumnerevans]

Just a couple questions. I think this looks pretty good, though.

[sumnerevans]

To address your comment in the original comment: I am pretty sure this is backwards compatible. No existing configs will break with this change.

[sumnerevans]

@ashinkarov please run ./format from the root of the repo to format the code.

[teto]

we can keep the interface but the logic should be moved to nixpkgs in the long term. Also worth a test.

[ashinkarov]

@ashinkarov please run ./format from the root of the repo to format the code.

Done.

[ashinkarov]

we can keep the interface but the logic should be moved to nixpkgs in the long term. Also worth a test.

@teto , I have tried extending neovim tests in the last commit. However, I am having trouble when executing the instance of neovim. I'd like to run something like nvim -c "lua require('lua-utf8')" -c "q", but the following attempt doesn't work:

${programs.neovim}/bin/nvim -c "lua require('lua-utf8')" -c "q"

(seems like it is stuck in an infinite loop). Sorry for stupid questions, but I have zero familiarity with the framework.

[stale]

Thank you for your contribution! I marked this pull request as stale due to inactivity. If this remains inactive for another 7 days, I will close this PR. Please read the relevant sections below before commenting.

If you are the original author of the PR

• GitHub sometimes doesn't notify people who commented / reviewed a PR previously, when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
• If it is unfinished but you plan to finish it, please mark it as a draft.
• If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
• To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the issue

• If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.