fish: remove promptInit in favor of interactiveShellInit#2231
Merged
sumnerevans merged 5 commits intonix-community:masterfrom Oct 27, 2021
kidonng:patch-3
Merged
fish: remove promptInit in favor of interactiveShellInit#2231sumnerevans merged 5 commits intonix-community:masterfrom kidonng:patch-3
promptInit in favor of interactiveShellInit#2231sumnerevans merged 5 commits intonix-community:masterfrom
kidonng:patch-3
Conversation
sumnerevans
suggested changes
Jul 29, 2021
This was referenced Aug 8, 2021
|
Thank you for your contribution! I marked this pull request as stale due to inactivity. If this remains inactive for another 7 days, I will close this PR. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the issue
|
Contributor
Author
|
Bump, this is still relevant. |
sumnerevans
approved these changes
Oct 27, 2021
betaboon
added a commit
to betaboon/home-manager
that referenced
this pull request
Oct 28, 2021
7 tasks
danth
added a commit
to nix-community/stylix
that referenced
this pull request
Oct 28, 2021
berbiche
pushed a commit
that referenced
this pull request
Oct 29, 2021
peterhoeg
pushed a commit
to peterhoeg/home-manager
that referenced
this pull request
Nov 4, 2021
…munity#2231) * fish: remove `promptInit` in favor of `interactiveShellInit` * Oops * starship: replace `promptInit` with `interactiveShellInit` * autojump: replace `promptInit` with `interactiveShellInit` * Add `mkRemovedOptionModule` for `programs.fish.promptInit`
peterhoeg
pushed a commit
to peterhoeg/home-manager
that referenced
this pull request
Nov 4, 2021
yvt
added a commit
to yvt/dotfiles
that referenced
this pull request
Nov 28, 2021
…veShellInit` This change was necessitated by the following PR: <nix-community/home-manager#2231>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
promptInitdoes nothing special and can already be implemented viainteractiveShellInit, so I suggest just keep the latter.However there are some things I'm not too sure:
programs.fish.interactiveShellInit(which "add completions generated by Home Manager to $fish_complete_path") config, but is it a default value? Will it take effect if users provide a custominteractiveShellInit? If that's the case then it should be fixed (and the code looks horrible to me, so we may also have a chance to rewrite it at the same time).Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.