nixos/fish: remove promptInit in favor of interactiveShellInit

[kidonng]

Motivation for this change

Derived from nix-community/home-manager#2231

promptInit does nothing special and can already be implemented via interactiveShellInit, so I suggest just keep the latter.

Things are slightly different in NixOS than Home Manager that both bash and zsh have a meaningful promptInit, so it may also be kept for consistency.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[Flakebi]

Looks good to me. It doesn’t make sense to have two options that do exactly the same.

[dasj19]

I checked NixOS options:
promptInit: https://search.nixos.org/options?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=promptInit
interactiveShellInit: https://search.nixos.org/options?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=interactiveShellInit

As you can see promptInit and interactiveShellInit are present for the 3 popular shells bash zsh and fish and it makes sense to keep those options in sync. Now if promptInit should be removed from fish can the same be done for bash and zsh?

I think that the options should be consistent to not make shell tranzitioning a pain-in-the-ass

[kidonng]

As you can see promptInit and interactiveShellInit are present for the 3 popular shells bash zsh and fish and it makes sense to keep those options in sync. Now if promptInit should be removed from fish can the same be done for bash and zsh?

This is already noted in the PR description. If we want to keep them consistent we probably want to make a custom prompt in fish's promptInit.

I think that the options should be consistent to not make shell tranzitioning a pain-in-the-ass

fish is not POSIX so the transition won't be trivial however. You can't expect to rename config key from bash/zsh to fish and everything just works.

[drupol]

@kidonng,

Could you please give a refresh this PR so we can move forward?

Thanks!

[dasj19]

will be nice to have this in the near future. please update the PR