Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: granular builder #297

Merged
merged 5 commits into from
Sep 20, 2022
Merged

php: granular builder #297

merged 5 commits into from
Sep 20, 2022

Conversation

tinybeachthor
Copy link
Contributor

@tinybeachthor tinybeachthor commented Sep 14, 2022 •
edited
Loading

Towards #240
After #296

Add a granular builder.

  • granular builder
  • docs
  • devshell

@tinybeachthor tinybeachthor marked this pull request as ready for review September 17, 2022 21:12
@DavHau DavHau merged commit a9dc29d into nix-community:main Sep 20, 2022
@DavHau
Copy link
Member

DavHau commented Sep 20, 2022

Is this builder preferably in any case? If it doesn't have downsides, we could consider removing the non-granular builder.

@tinybeachthor
Copy link
Contributor Author

@DavHau
The simple builder can build some more complex packages, where the granular fails for now.
The granular builder cannot handle composer plugins yet correctly, while the simple builder can.
Maybe we can remove it later once the granular builder is expanded a little more.

@DavHau DavHau added the summer-of-nix Issues/PRs opened by SoN participants label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
summer-of-nix Issues/PRs opened by SoN participants
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinybeachthor @DavHau