Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: improvements & fixes #296

Merged
merged 9 commits into from
Sep 16, 2022
Merged

php: improvements & fixes #296

merged 9 commits into from
Sep 16, 2022

Conversation

tinybeachthor
Copy link
Contributor

@tinybeachthor tinybeachthor commented Sep 14, 2022

Towards #240

  • use php extensions from composer.json and dependencies
  • handle inline version aliases ("dev-master as 1.3.1")
  • only do semver match on version-like constraints
  • link bins from composer.json
  • abort build on incompatible php version
  • fix semver ^ comparison
  • refactor & cleanup translators
  • refactor & simplify semver

@tinybeachthor tinybeachthor mentioned this pull request Sep 14, 2022
6 tasks
@tinybeachthor tinybeachthor marked this pull request as ready for review September 14, 2022 19:09
@aszenz
Copy link
Contributor

aszenz commented Sep 15, 2022

@tinybeachthor
Cool the build now works on the main branch: https://github.com/aszenz/php-app-nix/tree/main

But when i try it on a simpler composer.json here on https://github.com/aszenz/php-app-nix/tree/dev-constraint-error it fails showing:

error: Constraint "dev" could not be parsed

@tinybeachthor
Copy link
Contributor Author

@aszenz
Fixed now, it was trying to do semver match on all version constraints, even on something like dev-master.
I've added a guard to only semver check constraints where it makes sense.

@DavHau DavHau merged commit 25be741 into nix-community:main Sep 16, 2022
@DavHau DavHau added the summer-of-nix Issues/PRs opened by SoN participants label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
summer-of-nix Issues/PRs opened by SoN participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants