Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: impure translator composer-json + fix composer-lock #262

Merged
merged 13 commits into from
Aug 28, 2022

Conversation

tinybeachthor
Copy link
Contributor

@tinybeachthor tinybeachthor commented Aug 23, 2022

Towards #240

Found out a couple of issues with composer-lock translator (mostly semver resolution).

  • fix php semver resolution
  • handle composer dependency replace
  • handle composer dependency provide
  • impure translator composer-json
  • fix dev dependencies resolution
  • add php subsystems docs section

@tinybeachthor tinybeachthor changed the title php: impure translator composer-json php: impure translator composer-json + fix composer-lock Aug 24, 2022
@DavHau
Copy link
Member

DavHau commented Aug 25, 2022

  • php example (can we do this without a builder?)

Actually we need a builder first, in order for the example to work.

@tinybeachthor tinybeachthor force-pushed the php-translator-composer-json branch from 730d332 to 3e163b2 Compare August 25, 2022 23:49
@tinybeachthor tinybeachthor force-pushed the php-translator-composer-json branch from 3e163b2 to dfc15e9 Compare August 26, 2022 00:11
@tinybeachthor tinybeachthor marked this pull request as ready for review August 26, 2022 00:28
@tinybeachthor
Copy link
Contributor Author

PHP packages have their own name but can also replace other packages or provide implementations - both of which can define their own versions.

This PR fixes the composer-lock translator to take replace and provide into account + some issues with the semver parsing (composer semver is a bit relaxed compared to the standard: ~ is treated almost like ^).

@DavHau DavHau merged commit ab769ee into nix-community:main Aug 28, 2022
@DavHau DavHau added the summer-of-nix Issues/PRs opened by SoN participants label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
summer-of-nix Issues/PRs opened by SoN participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants