Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: add translator composer-lock #258

Merged
merged 8 commits into from
Aug 23, 2022

Conversation

tinybeachthor
Copy link
Contributor

@tinybeachthor tinybeachthor commented Aug 18, 2022

Towards #240

Seems like composer.lock does not write hashes for dependency archives,
for a pure translator we will need to use git sources only, therefore building everything from source.

TODO:

  • resolve requires into pinned versions
  • php version
  • php extensions
  • dev dependencies

@tinybeachthor tinybeachthor marked this pull request as ready for review August 21, 2022 23:32
@DavHau DavHau merged commit 6a688b9 into nix-community:main Aug 23, 2022
@DavHau
Copy link
Member

DavHau commented Aug 23, 2022

It's very nice to have support for php now.
Possible future work:

  • add example for php to /examples
  • add subsystem entry for php to the docs
  • add impure translator for projects which do not contain a composer lock file (Does that use case make sense?)

@tinybeachthor
Copy link
Contributor Author

@DavHau

impure translator does make a lot of sense, a lot of php projects don't commit composer.lock (some to get auto-updating-like behaviour, some just don't).
+
Docs entry on php subsystems (translators only so far).
=
#262

Next up builder + examples

@DavHau DavHau added the summer-of-nix Issues/PRs opened by SoN participants label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
summer-of-nix Issues/PRs opened by SoN participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants