Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds optional dependencies to features when they are enabled indirectly #185

Merged
merged 2 commits into from
Apr 24, 2021
Merged

Adds optional dependencies to features when they are enabled indirectly #185

merged 2 commits into from
Apr 24, 2021

Commits on Apr 22, 2021

  1. apply clippy suggestions

    @pandaman64
    pandaman64 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    d8ddf41 View commit details
    Browse the repository at this point in the history

  2. Adds optional dependencies to features when they are enabled indirectly. 

    When Cargo sees a dependency feature `opt_crate/feat` for an optional dependency `opt_crate`,
it implicitly adds `opt_crate` to the feature set for the current crate.
For example, `num-rational` crate relies on this behavior for importing `num-bigint`, which is optional.
This patch lets crate2nix mimic this behavior.

Closes nix-community#146 and nix-community#182.
    @pandaman64
    pandaman64 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    94968de View commit details
    Browse the repository at this point in the history