Adds optional dependencies to features when they are enabled indirectly #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Cargo sees a dependency feature `opt_crate/feat` for an optional dependency `opt_crate`, it implicitly adds `opt_crate` to the feature set for the current crate. For example, `num-rational` crate relies on this behavior for importing `num-bigint`, which is optional. This patch lets crate2nix mimic this behavior. Closes nix-community#146 and nix-community#182.
|
Woah, thank you, @pandaman64! Prime example of a PR I love.
🎆 |
|
Thanks! Just confirming that it works for us too, I tried it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Cargo sees a dependency feature
opt_crate/featfor an optional dependencyopt_crate,it implicitly adds
opt_crateto the feature set for the current crate.For example,
num-rationalcrate relies on this behavior for importingnum-bigint, which is optional.This patch lets crate2nix mimic this behavior.
Main changes are in crate2nix/templates/nix/crate2nix/default.nix
I also modified test cases(crate2nix/templates/nix/crate2nix/tests/packageFeatures.nix) so that they match what Cargo does.
Closes #146, #182.