Skip to content

Replace Regex.Match with Regex.IsMatch #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonyqus merged 2 commits into from
Feb 25, 2026
Merged

Replace Regex.Match with Regex.IsMatch #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf2ecf2
fix compiling error by IDE suggestion
antony-liu Feb 23, 2026
bd965ec
Merge branch 'nissl-lab:master' into master
antony-liu Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main/SS/Formula/Functions/Indirect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ private static ValueEval EvaluateIndirect(OperationEvaluationContext ec, String

String refStrPart1;
String refStrPart2;
if (Table.IsStructuredReference.Match(refText).Success)
if (Table.IsStructuredReference.IsMatch(refText))
{ // The argument is structured reference
Area3DPxg areaPtg = null;
try
Expand Down
2 changes: 1 addition & 1 deletion main/SS/UserModel/DateUtil.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,7 @@ public static bool IsADateFormat(int formatIndex, String formatString)
}
// Ensure it has some date letters in it
// (Avoids false positives on the rest of pattern 3)
if (!date_ptrn3a.Match(fs).Success)
if (!date_ptrn3a.IsMatch(fs))
//if (!Regex.Match(fs, "[yYmMdDhHsS]").Success)
{
return false;
Expand Down
Loading