Skip to content

Replace Regex.Match with Regex.IsMatch#1698

Merged
tonyqus merged 2 commits into
nissl-lab:masterfrom
antony-liu:master
Feb 25, 2026
Merged

Replace Regex.Match with Regex.IsMatch#1698
tonyqus merged 2 commits into
nissl-lab:masterfrom
antony-liu:master

Conversation

@antony-liu
Copy link
Copy Markdown
Collaborator

No description provided.

@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Feb 25, 2026

I don't see compiling error before this change. Is this title correct?

@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Feb 25, 2026

Please check if there are unit tests to cover these changes

@antony-liu
Copy link
Copy Markdown
Collaborator Author

Yes, my IDE shows a compiling error, CA1874: Use 'Regex.IsMatch'.
QQ20260225-183254

My IDE version:
Microsoft Visual Studio Community 2022
version 17.14.27 (February 2026)

@antony-liu
Copy link
Copy Markdown
Collaborator Author

Please check if there are unit tests to cover these changes

There are unit tests for DateUtils.cs, but no test for Indirect.cs.

@tonyqus tonyqus merged commit 2273c44 into nissl-lab:master Feb 25, 2026
2 of 3 checks passed
@tonyqus tonyqus added this to the NPOI 2.7.6 milestone Feb 25, 2026
@tonyqus tonyqus changed the title Fix compiling error by IDE suggestion Replace Match with IsMatch Feb 27, 2026
@tonyqus tonyqus changed the title Replace Match with IsMatch Replace Regex.Match with Regex.IsMatch Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants