Skip to content

Fix NPE issue in PackageRelationshipCollection#1330

Merged
tonyqus merged 1 commit into
nissl-lab:masterfrom
tonyqus:poi_bug_66425
May 4, 2024
Merged

Fix NPE issue in PackageRelationshipCollection#1330
tonyqus merged 1 commit into
nissl-lab:masterfrom
tonyqus:poi_bug_66425

Conversation

@tonyqus
Copy link
Copy Markdown
Member

@tonyqus tonyqus commented May 4, 2024

sync code from apache/poi@cdb2ba1

fix #1229

@tonyqus tonyqus requested a review from Bykiev May 4, 2024 05:57
@tonyqus tonyqus changed the title Fix #1229 Fix NPE issue May 4, 2024
@tonyqus tonyqus changed the title Fix NPE issue Fix NPE issue in PackageRelationshipCollection May 4, 2024
Copy link
Copy Markdown
Collaborator

@Bykiev Bykiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should focus on tests, many of them are failing

@tonyqus
Copy link
Copy Markdown
Member Author

tonyqus commented May 4, 2024

@Bykiev I checked the test cases. The failure is caused by #1287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several possible NPE

2 participants