Skip to content

[POI-Bug-67475] Better support for edge cases in TEXT function.#1287

Merged
tonyqus merged 1 commit into
nissl-lab:masterfrom
superrnovae:text_function
May 3, 2024
Merged

[POI-Bug-67475] Better support for edge cases in TEXT function.#1287
tonyqus merged 1 commit into
nissl-lab:masterfrom
superrnovae:text_function

Conversation

@superrnovae
Copy link
Copy Markdown
Contributor

@superrnovae superrnovae commented Mar 6, 2024

Bugzilla URL: https://bz.apache.org/bugzilla/show_bug.cgi?id=67475
SVN revision: https://svn.apache.org/viewvc?view=revision&revision=1912973

This also fixes parsing of doubles in DataFormatter as it will now pass current culture object to double.Parse() method.

@tonyqus tonyqus added this to the NPOI 2.7.1 milestone Mar 6, 2024
@tonyqus tonyqus changed the title [Bug-67475] Better support for edge cases in TEXT function. [POI-Bug-67475] Better support for edge cases in TEXT function. May 3, 2024
@tonyqus tonyqus merged commit 09966aa into nissl-lab:master May 3, 2024
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented May 4, 2024

The changes in FormatRawCellContents method caused the failure of TestDataFormatter.TestGrouping and TestDataFormatter.TestLocale. I have to revert the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants