Skip to content

Build process maintenance 3rd#1032

Merged
tonyqus merged 2 commits into
nissl-lab:masterfrom
9rnsr:build_maintenance3
Mar 4, 2023
Merged

Build process maintenance 3rd#1032
tonyqus merged 2 commits into
nissl-lab:masterfrom
9rnsr:build_maintenance3

Conversation

@9rnsr
Copy link
Copy Markdown
Contributor

@9rnsr 9rnsr commented Feb 27, 2023

Next of #1031.

  1. Make tests runnable for .NET Framework v4.7.2 with VS2022

    In NPOI.Test.sln I got internal errors during test case search with the combination of VS2022 + NUnit3TestAdapter 4.2.1, then I cannot execute any test cases those are listed in Test Explorer.
    To fix the error, update NUnit3TestAdapter version to 4.3.1 .

    In NPOI.Core.Test.sln, the problem didn't happen, but I also update NUnit3TestAdapter for consistency.

  2. Update NuGet packages versions for consistency between Core and Framework csprojs

    Microsoft.SourceLink.GitHub --> 1.1.1 (in Directory.Build.props)
    NSubstitute --> 4.2.2
    NUnit --> 3.13.3

In `NPOI.Test.sln` I got internal errors during test case search with the combination of
VS2022 + NUnit3TestAdapter 4.2.1, then I cannot execute any test cases those are listed in Test Explorer.
To fix the error, update NUnit3TestAdapter version to 4.3.1 .

In `NPOI.Core.Test.sln`, the problem didn't happen, but I also update NUnit3TestAdapter for consistency.
@9rnsr 9rnsr force-pushed the build_maintenance3 branch from 2e1b691 to db55ee6 Compare February 28, 2023 11:48
…work csprojs

Microsoft.SourceLink.GitHub  --> 1.1.1  (in `Directory.Build.props`)
NSubstitute  --> 4.2.2
NUnit  --> 3.13.3
@9rnsr 9rnsr force-pushed the build_maintenance3 branch from db55ee6 to 27e9661 Compare February 28, 2023 12:01
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Mar 4, 2023

LGTM

@tonyqus tonyqus added this to the NPOI 2.6.1 milestone Mar 4, 2023
@tonyqus tonyqus merged commit 60004ba into nissl-lab:master Mar 4, 2023
@9rnsr 9rnsr deleted the build_maintenance3 branch March 5, 2023 16:52
@tonyqus tonyqus added the cicd label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants