Skip to content

Build process maintenance#1028

Merged
tonyqus merged 3 commits into
nissl-lab:masterfrom
9rnsr:build_maintenance
Feb 27, 2023
Merged

Build process maintenance#1028
tonyqus merged 3 commits into
nissl-lab:masterfrom
9rnsr:build_maintenance

Conversation

@9rnsr
Copy link
Copy Markdown
Contributor

@9rnsr 9rnsr commented Feb 26, 2023

While trying to understand about the NPOI build process, I found some weird files and build settings in the repository. This PR is small build process maintenance.

  1. Share one assembly sign key file between projects

    There were many same npoi.snk files in the repository.
    Move the key file up to the root of repository, then refer it from each csproj files.

  2. Remove unused assembly sign key file pk.snk

    It's not used anywhere.

  3. Remove unused packages.config files

    Each csproj files are already migrated to use the PackageReference mode.

Move the key file npoi.snk upto the root of repository, then refer it from each csproj files.
Each csproj files are already migrated to use the PackageReference mode.
@tonyqus
Copy link
Copy Markdown
Member

tonyqus commented Feb 27, 2023

LGTM

@tonyqus tonyqus added this to the NPOI 2.6.1 milestone Feb 27, 2023
@tonyqus tonyqus merged commit 676aca1 into nissl-lab:master Feb 27, 2023
@9rnsr
Copy link
Copy Markdown
Contributor Author

9rnsr commented Feb 27, 2023

Thanks! I opened #1033 which describes why I started to maintain build process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants