FIX: Avoid excessive etelemetry pings #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where `check_latest_version` returned None, each time `BaseInterface.__init__` was called would lead to another server ping. This avoids this loop by falling to a string, n/a, if the server fails to produce a version.
Codecov Report
@@ Coverage Diff @@
## master #3484 +/- ##
==========================================
- Coverage 65.25% 63.63% -1.63%
==========================================
Files 309 309
Lines 40848 40848
Branches 5378 5378
==========================================
- Hits 26657 25993 -664
- Misses 13117 13830 +713
+ Partials 1074 1025 -49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
effigies
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where
check_latest_versionreturned None, each timeBaseInterface.__init__was called would lead to another server ping.This avoids this loop by falling to a string, n/a, if the server fails
to produce a version.
Summary
Fixes #3483 .
List of changes proposed in this PR (pull-request)