Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent excessive etelemetry pings #3483

Closed
effigies opened this issue Jun 13, 2022 · 1 comment · Fixed by #3484
Closed

Prevent excessive etelemetry pings #3483

effigies opened this issue Jun 13, 2022 · 1 comment · Fixed by #3484

Comments

@effigies
Copy link
Member

When etelemetry is down, nipype can spend excessive time re-trying instead of recording a failure mode.

On the one hand, this is a problem with the client. On the other, we should probably code defensively against bugs in the etelemetry client.

@mgxd
Copy link
Member

mgxd commented Jun 13, 2022

if BaseInterface._etelemetry_version_data is None:
BaseInterface._etelemetry_version_data = check_latest_version()

I think the easiest thing to do would be to add a check if None is returned, and if so set BaseInterface._etelemetry_version_data to n/a or something equivalent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants