-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Permit recent nilearns #2841
Conversation
c46d682
to
442e0b9
Compare
Codecov Report
@@ Coverage Diff @@
## master #2841 +/- ##
===========================================
+ Coverage 50.4% 67.52% +17.11%
===========================================
Files 126 299 +173
Lines 25304 39487 +14183
Branches 0 5220 +5220
===========================================
+ Hits 12755 26664 +13909
+ Misses 12549 12112 -437
- Partials 0 711 +711
Continue to review full report at Codecov.
|
nilearn 0.4.2 to 0.5.0 was a pretty huge change. While they had two pre-releases, it looks like our nilearn tests don't run on Travis, which is where we do our pre-release tests. So I'm pinning to the pre-releases, to help narrow down the window in which the change happened. It's unclear whether this is a nilearn bug. |
I've decided this is a nilearn bug: nilearn/nilearn#1891, introduced in nilearn/nilearn#1711. We can also try to accommodate this version, by making sure that we pass in appropriate |
Last two commits verify the source of the failure. (I cancelled all but the pytest jobs.) |
0.5.1 was released 7 days ago, perhaps this can now be re-tested and merged? |
7912cf1
to
e38a07a
Compare
Rebased. Doubt it'll work. |
Nope. They did some weird stuff and were unwilling to revert, and I haven't found time to dig through their code and figure out how to restore functionality. |
e38a07a
to
fd52a30
Compare
8c368c9
to
6270778
Compare
@satra Good to go? |
Summary
Fixes #2791.
List of changes proposed in this PR (pull-request)
Acknowledgment