Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Permit recent nilearns #2841

Merged
merged 1 commit into from
May 19, 2020
Merged

Conversation

effigies
Copy link
Member

@effigies effigies commented Jan 2, 2019

Summary

Fixes #2791.

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov-io
Copy link

codecov-io commented Jan 3, 2019

Codecov Report

Merging #2841 into master will increase coverage by 17.11%.
The diff coverage is 58.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2841       +/-   ##
===========================================
+ Coverage    50.4%   67.52%   +17.11%     
===========================================
  Files         126      299      +173     
  Lines       25304    39487    +14183     
  Branches        0     5220     +5220     
===========================================
+ Hits        12755    26664    +13909     
+ Misses      12549    12112      -437     
- Partials        0      711      +711
Flag Coverage Δ
#smoketests 53.02% <32.82%> (+2.61%) ⬆️
#unittests 64.75% <51.97%> (?)
Impacted Files Coverage Δ
nipype/interfaces/ants/base.py 60% <ø> (+11.06%) ⬆️
nipype/interfaces/ants/__init__.py 100% <ø> (ø) ⬆️
nipype/interfaces/base/core.py 86.96% <ø> (+20.36%) ⬆️
nipype/interfaces/afni/preprocess.py 82.02% <ø> (ø)
nipype/interfaces/afni/svm.py 97.61% <ø> (ø)
nipype/interfaces/afni/utils.py 81.86% <ø> (ø)
nipype/interfaces/ants/resampling.py 83.69% <ø> (+36.92%) ⬆️
nipype/interfaces/base/specs.py 93.33% <ø> (+9.75%) ⬆️
nipype/interfaces/ants/utils.py 88.28% <ø> (+3.46%) ⬆️
nipype/interfaces/ants/segmentation.py 74.39% <ø> (+26.57%) ⬆️
... and 340 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd52a30...8c368c9. Read the comment docs.

@effigies
Copy link
Member Author

effigies commented Jan 3, 2019

nilearn 0.4.2 to 0.5.0 was a pretty huge change. While they had two pre-releases, it looks like our nilearn tests don't run on Travis, which is where we do our pre-release tests.

So I'm pinning to the pre-releases, to help narrow down the window in which the change happened. It's unclear whether this is a nilearn bug.

@effigies
Copy link
Member Author

effigies commented Jan 3, 2019

I've decided this is a nilearn bug: nilearn/nilearn#1891, introduced in nilearn/nilearn#1711.

We can also try to accommodate this version, by making sure that we pass in appropriate dtypes, but I think it's more appropriately handled on their end.

@effigies effigies changed the title MAINT: nilearn 0.5 compatibility [WIP] MAINT: nilearn 0.5 compatibility Jan 3, 2019
@effigies
Copy link
Member Author

effigies commented Jan 3, 2019

Last two commits verify the source of the failure. (I cancelled all but the pytest jobs.)

@satra
Copy link
Member

satra commented Apr 18, 2019

0.5.1 was released 7 days ago, perhaps this can now be re-tested and merged?

@effigies effigies force-pushed the maint/nilearn_0_5 branch from 7912cf1 to e38a07a Compare April 18, 2019 23:40
@effigies
Copy link
Member Author

Rebased. Doubt it'll work.

@effigies
Copy link
Member Author

Nope. They did some weird stuff and were unwilling to revert, and I haven't found time to dig through their code and figure out how to restore functionality.

@effigies effigies force-pushed the maint/nilearn_0_5 branch from 8c368c9 to 6270778 Compare May 19, 2020 14:34
@effigies effigies changed the title [WIP] MAINT: nilearn 0.5 compatibility MAINT: Permit recent nilearns May 19, 2020
@effigies
Copy link
Member Author

@satra Good to go?

@effigies effigies added this to the 1.5.0 milestone May 19, 2020
@satra satra merged commit 994bef3 into nipy:master May 19, 2020
@effigies effigies deleted the maint/nilearn_0_5 branch May 19, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nilearn 0.5.0 breaks tests
3 participants