Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nilearn 0.5.0 breaks tests #2791

Closed
oesteban opened this issue Nov 22, 2018 · 7 comments · Fixed by #2841
Closed

Nilearn 0.5.0 breaks tests #2791

oesteban opened this issue Nov 22, 2018 · 7 comments · Fixed by #2841
Labels
Milestone

Comments

@oesteban
Copy link
Contributor

Summary

The latest release of nilearn broke master.

@djarecka
Copy link
Collaborator

@satra @effigies - do you have any thoughts about sklearn version?

I've come back to the nipype_tutorial that also didn't like nilearn recently, and I moved to 0.4.2, but now heaving issue ModuleNotFoundError: No module named 'sklearn.externals.joblib' , etc. I can explore more and open a new issue with full error, but just wanna check quickly first.

@satra
Copy link
Member

satra commented May 20, 2020

@djarecka - i thought we just fixed this yesterday on nipype master.

@effigies
Copy link
Member

You can use sklearn<0.23 or recent nilearn.

@djarecka
Copy link
Collaborator

@effigies - what do you mean by recent nilearn? When I have 0.6.2 the notebok still fails

@effigies
Copy link
Member

With ModuleNotFoundError: No module named 'sklearn.externals.joblib'? Link to a CI?

@djarecka
Copy link
Collaborator

@effigies - no, With ModuleNotFoundError was with nilearn 0.4.2, but after your and Satra's suggestion, I tried once again with master nipype and pip-current version of nilearn and it seems to me that the problem is exactly the same as 2 months ago (no error, but nipype is hanging when rerunning a workflow).

Sorry for the confusion, let me run the full example with CI and open an issue. For now, I was testing locally.

@djarecka
Copy link
Collaborator

right now, I'm not able to build the image on circleCI, not sure why. Will come back to this tomorrow and let you know

@effigies effigies added this to the 1.5.0 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants